From a7d954eb310bd17b06bad697ebccb221ef615c8e Mon Sep 17 00:00:00 2001 From: Alexander Aprelev Date: Wed, 29 Aug 2018 10:25:19 -0700 Subject: [PATCH] Add TODOs to remove lint ignore directives. (#21170) This is follow-up to https://github.com/flutter/flutter/pull/21143. --- packages/flutter/lib/src/widgets/platform_view.dart | 1 + packages/flutter/lib/src/widgets/scroll_view.dart | 1 + packages/flutter/lib/src/widgets/single_child_scroll_view.dart | 1 + 3 files changed, 3 insertions(+) diff --git a/packages/flutter/lib/src/widgets/platform_view.dart b/packages/flutter/lib/src/widgets/platform_view.dart index e753c48a56..146888ac10 100644 --- a/packages/flutter/lib/src/widgets/platform_view.dart +++ b/packages/flutter/lib/src/widgets/platform_view.dart @@ -51,6 +51,7 @@ class AndroidView extends StatefulWidget { /// The `viewType`, `hitTestBehavior`, and `gestureRecognizers` parameters must not be null. /// If `creationParams` is not null then `creationParamsCodec` must not be null. AndroidView({ // ignore: prefer_const_constructors_in_immutables + // TODO(aam): Remove lint ignore above once dartbug.com/34297 is fixed Key key, @required this.viewType, this.onPlatformViewCreated, diff --git a/packages/flutter/lib/src/widgets/scroll_view.dart b/packages/flutter/lib/src/widgets/scroll_view.dart index 98bb16988b..b6ed75f2cc 100644 --- a/packages/flutter/lib/src/widgets/scroll_view.dart +++ b/packages/flutter/lib/src/widgets/scroll_view.dart @@ -51,6 +51,7 @@ abstract class ScrollView extends StatelessWidget { /// /// If the [primary] argument is true, the [controller] must be null. ScrollView({ // ignore: prefer_const_constructors_in_immutables + // TODO(aam): Remove lint ignore above once dartbug.com/34297 is fixed Key key, this.scrollDirection = Axis.vertical, this.reverse = false, diff --git a/packages/flutter/lib/src/widgets/single_child_scroll_view.dart b/packages/flutter/lib/src/widgets/single_child_scroll_view.dart index cff514abd2..4e64d34a81 100644 --- a/packages/flutter/lib/src/widgets/single_child_scroll_view.dart +++ b/packages/flutter/lib/src/widgets/single_child_scroll_view.dart @@ -184,6 +184,7 @@ import 'scrollable.dart'; class SingleChildScrollView extends StatelessWidget { /// Creates a box in which a single widget can be scrolled. SingleChildScrollView({ // ignore: prefer_const_constructors_in_immutables + // TODO(aam): Remove lint ignore above once dartbug.com/34297 is fixed Key key, this.scrollDirection = Axis.vertical, this.reverse = false,