From 9ec3cabf99beb3f3dc632b123aea4c60bb2fa5ec Mon Sep 17 00:00:00 2001 From: Adam Barth Date: Mon, 19 Sep 2016 14:01:02 -0700 Subject: [PATCH] Rename TabSelection.registerAnimationListener to addAnimationListener (#5932) This name is more consistent with our other names. Fixes #4714 --- packages/flutter/lib/src/material/tabs.dart | 22 ++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/packages/flutter/lib/src/material/tabs.dart b/packages/flutter/lib/src/material/tabs.dart index 42061ec390..713710c05a 100644 --- a/packages/flutter/lib/src/material/tabs.dart +++ b/packages/flutter/lib/src/material/tabs.dart @@ -649,8 +649,8 @@ class TabBarSelectionState extends State> { /// Calls listener methods every time the value or status of the selection animation changes. /// - /// Listeners can be removed with [unregisterAnimationListener]. - void registerAnimationListener(TabBarSelectionAnimationListener listener) { + /// Listeners can be removed with [removeAnimationListener]. + void addAnimationListener(TabBarSelectionAnimationListener listener) { _animationListeners.add(listener); _controller ..addStatusListener(listener.handleStatusChange) @@ -659,8 +659,8 @@ class TabBarSelectionState extends State> { /// Stop calling listener methods every time the value or status of the animation changes. /// - /// Listeners can be added with [registerAnimationListener]. - void unregisterAnimationListener(TabBarSelectionAnimationListener listener) { + /// Listeners can be added with [addAnimationListener]. + void removeAnimationListener(TabBarSelectionAnimationListener listener) { _animationListeners.remove(listener); _controller ..removeStatusListener(listener.handleStatusChange) @@ -672,7 +672,7 @@ class TabBarSelectionState extends State> { _controller.stop(); for (TabBarSelectionAnimationListener listener in _animationListeners.toList()) { listener.handleSelectionDeactivate(); - unregisterAnimationListener(listener); + removeAnimationListener(listener); } assert(_animationListeners.isEmpty); _writeValue(); @@ -772,9 +772,9 @@ class _TabBarState extends ScrollableState> implements TabBarSelect void _initSelection(TabBarSelectionState newSelection) { if (_selection == newSelection) return; - _selection?.unregisterAnimationListener(this); + _selection?.removeAnimationListener(this); _selection = newSelection; - _selection?.registerAnimationListener(this); + _selection?.addAnimationListener(this); if (_selection != null) _lastSelectedIndex = _selection.index; } @@ -791,7 +791,7 @@ class _TabBarState extends ScrollableState> implements TabBarSelect @override void dispose() { - _selection?.unregisterAnimationListener(this); + _selection?.removeAnimationListener(this); super.dispose(); } @@ -1110,9 +1110,9 @@ class _TabBarViewState extends PageableListState> implements Ta void _initSelection(TabBarSelectionState newSelection) { if (_selection == newSelection) return; - _selection?.unregisterAnimationListener(this); + _selection?.removeAnimationListener(this); _selection = newSelection; - _selection?.registerAnimationListener(this); + _selection?.addAnimationListener(this); if (_selection != null) _updateItemsAndScrollBehavior(); } @@ -1126,7 +1126,7 @@ class _TabBarViewState extends PageableListState> implements Ta @override void dispose() { - _selection?.unregisterAnimationListener(this); + _selection?.removeAnimationListener(this); super.dispose(); }