From 9e3a0d30c98ecf55281454f47228f112c749f0fc Mon Sep 17 00:00:00 2001 From: Phil Quitslund Date: Fri, 8 Feb 2019 13:46:01 -0800 Subject: [PATCH] remove super_goes_last (#27690) In Dart 2, it is a compile-time error if a superinitializer appears in an initializer list at any other position than at the end so this rule is made redundant by the Dart analyzer's basic checks and is no longer necessary. --- analysis_options.yaml | 2 +- packages/flutter/lib/analysis_options_user.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/analysis_options.yaml b/analysis_options.yaml index 9fa618bf57..0f3f70d3cc 100644 --- a/analysis_options.yaml +++ b/analysis_options.yaml @@ -151,7 +151,7 @@ linter: - sort_constructors_first - sort_pub_dependencies - sort_unnamed_constructors_first - - super_goes_last + # - super_goes_last # no longer needed w/ Dart 2 - test_types_in_equals - throw_in_finally # - type_annotate_public_apis # subset of always_specify_types diff --git a/packages/flutter/lib/analysis_options_user.yaml b/packages/flutter/lib/analysis_options_user.yaml index 01c274a8b1..8fc78573b6 100644 --- a/packages/flutter/lib/analysis_options_user.yaml +++ b/packages/flutter/lib/analysis_options_user.yaml @@ -67,7 +67,7 @@ linter: - slash_for_doc_comments # - sort_constructors_first # - sort_unnamed_constructors_first - - super_goes_last + # - super_goes_last # no longer needed w/ Dart 2 - test_types_in_equals - throw_in_finally # - type_annotate_public_apis # subset of always_specify_types