firka/flutter
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix ISSUE_TEMPLATE Ordering: 10 < 9, but 10 > 09 (#166455)

Browse Source 
Unfortunately `10_google3_bug.yml` comes before `2_bug.yml`.

This changes the name (slightly) of the issue templates based on the
instructions from GitHub on what to do when you have 10+ issue templates
(as a side-note: I wonder if we need/still use umbrella bugs for the
feature tracker, or two types of performance bugs)
This commit is contained in:
Matan Lurey
2025-04-02 17:24:34 -07:00
committed by GitHub
parent e359812a51
commit 997f742ac5
26 changed files with 35 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
packages/flutter/lib/src/foundation/assertions.dart
View File

@@ -717,7 +717,7 @@ class FlutterErrorDetails with Diagnosticable {
'provide substantially more information in this error message to help you determine '
'and fix the underlying cause.\n'
'In either case, please report this assertion by filing a bug on GitHub:\n'
' https://github.com/flutter/flutter/issues/new?template=2_bug.yml',
' https://github.com/flutter/flutter/issues/new?template=02_bug.yml',
),
);
}
@@ -863,7 +863,7 @@ class FlutterError extends Error with DiagnosticableTreeMixin implements Asserti
'\nThis error should still help you solve your problem, '
'however please also report this malformed error in the '
'framework by filing a bug on GitHub:\n'
' https://github.com/flutter/flutter/issues/new?template=2_bug.yml',
' https://github.com/flutter/flutter/issues/new?template=02_bug.yml',
),
]),
);
@@ -900,7 +900,7 @@ class FlutterError extends Error with DiagnosticableTreeMixin implements Asserti
'\nThis error should still help you solve your problem, '
'however please also report this malformed error in the '
'framework by filing a bug on GitHub:\n'
' https://github.com/flutter/flutter/issues/new?template=2_bug.yml',
' https://github.com/flutter/flutter/issues/new?template=02_bug.yml',
),
);
throw FlutterError.fromParts(message);

12
packages/flutter/lib/src/rendering/box.dart
View File

@@ -2076,7 +2076,7 @@ abstract class RenderBox extends RenderObject {
),
ErrorHint(
'If you are not writing your own RenderBox subclass, then this is not\n'
'your fault. Contact support: https://github.com/flutter/flutter/issues/new?template=2_bug.yml',
'your fault. Contact support: https://github.com/flutter/flutter/issues/new?template=02_bug.yml',
),
]),
),
@@ -2188,7 +2188,7 @@ abstract class RenderBox extends RenderObject {
),
ErrorHint(
'If you are not writing your own RenderBox subclass, then this is not\n'
'your fault. Contact support: https://github.com/flutter/flutter/issues/new?template=2_bug.yml',
'your fault. Contact support: https://github.com/flutter/flutter/issues/new?template=02_bug.yml',
),
]),
),
@@ -2646,7 +2646,7 @@ abstract class RenderBox extends RenderObject {
DiagnosticsProperty<Size>('Size', _size, style: DiagnosticsTreeStyle.errorProperty),
ErrorHint(
'If you are not writing your own RenderBox subclass, then this is not '
'your fault. Contact support: https://github.com/flutter/flutter/issues/new?template=2_bug.yml',
'your fault. Contact support: https://github.com/flutter/flutter/issues/new?template=02_bug.yml',
),
]);
}
@@ -2738,7 +2738,7 @@ abstract class RenderBox extends RenderObject {
...failures,
ErrorHint(
'If you are not writing your own RenderBox subclass, then this is not\n'
'your fault. Contact support: https://github.com/flutter/flutter/issues/new?template=2_bug.yml',
'your fault. Contact support: https://github.com/flutter/flutter/issues/new?template=02_bug.yml',
),
]);
}
@@ -2764,7 +2764,7 @@ abstract class RenderBox extends RenderObject {
ErrorDescription('The constraints used were $constraints.'),
ErrorHint(
'If you are not writing your own RenderBox subclass, then this is not\n'
'your fault. Contact support: https://github.com/flutter/flutter/issues/new?template=2_bug.yml',
'your fault. Contact support: https://github.com/flutter/flutter/issues/new?template=02_bug.yml',
),
]);
}
@@ -2779,7 +2779,7 @@ abstract class RenderBox extends RenderObject {
ErrorDescription('The constraints used were $constraints.'),
ErrorHint(
'If you are not writing your own RenderBox subclass, then this is not\n'
'your fault. Contact support: https://github.com/flutter/flutter/issues/new?template=2_bug.yml',
'your fault. Contact support: https://github.com/flutter/flutter/issues/new?template=02_bug.yml',
),
];

2
packages/flutter/lib/src/rendering/flex.dart
View File

@@ -1113,7 +1113,7 @@ class RenderFlex extends RenderBox
...addendum,
ErrorDescription(
"If none of the above helps enough to fix this problem, please don't hesitate to file a bug:\n"
' https://github.com/flutter/flutter/issues/new?template=2_bug.yml',
' https://github.com/flutter/flutter/issues/new?template=02_bug.yml',
),
]);
return true;

2
packages/flutter/lib/src/semantics/semantics.dart
View File

@@ -4143,7 +4143,7 @@ class SemanticsOwner extends ChangeNotifier {
ErrorHint(
'Consider removing the above invisible SemanticsNodes if they were added by your '
'RenderObject.assembleSemanticsNode implementation, or filing a bug on GitHub:\n'
' https://github.com/flutter/flutter/issues/new?template=2_bug.yml',
' https://github.com/flutter/flutter/issues/new?template=02_bug.yml',
),
]);
}());

2
packages/flutter/lib/src/widgets/framework.dart
View File

@@ -2899,7 +2899,7 @@ class BuildOwner {
ErrorHint(
'If you did not attempt to call scheduleBuildFor() yourself, then this probably '
'indicates a bug in the widgets framework. Please report it:\n'
' https://github.com/flutter/flutter/issues/new?template=2_bug.yml',
' https://github.com/flutter/flutter/issues/new?template=02_bug.yml',
),
]);
}

8
packages/flutter/test/foundation/assertions_test.dart
View File

@@ -240,7 +240,7 @@ void main() {
'This error should still help you solve your problem, however\n'
'please also report this malformed error in the framework by\n'
'filing a bug on GitHub:\n'
' https://github.com/flutter/flutter/issues/new?template=2_bug.yml\n'
' https://github.com/flutter/flutter/issues/new?template=02_bug.yml\n'
'═════════════════════════════════════════════════════════════════\n',
);
}
@@ -277,7 +277,7 @@ void main() {
'This error should still help you solve your problem, however\n'
'please also report this malformed error in the framework by\n'
'filing a bug on GitHub:\n'
' https://github.com/flutter/flutter/issues/new?template=2_bug.yml\n'
' https://github.com/flutter/flutter/issues/new?template=02_bug.yml\n'
'═════════════════════════════════════════════════════════════════\n',
);
}
@@ -306,7 +306,7 @@ void main() {
'This error should still help you solve your problem, however\n'
'please also report this malformed error in the framework by\n'
'filing a bug on GitHub:\n'
' https://github.com/flutter/flutter/issues/new?template=2_bug.yml\n'
' https://github.com/flutter/flutter/issues/new?template=02_bug.yml\n'
'═════════════════════════════════════════════════════════════════\n',
);
}
@@ -406,7 +406,7 @@ void main() {
'provide substantially more information in this error message to help you determine '
'and fix the underlying cause.\n'
'In either case, please report this assertion by filing a bug on GitHub:\n'
' https://github.com/flutter/flutter/issues/new?template=2_bug.yml',
' https://github.com/flutter/flutter/issues/new?template=02_bug.yml',
);
expect(builder.properties[4] is ErrorSpacer, true);
final DiagnosticsStackTrace trace = builder.properties[5] as DiagnosticsStackTrace;

4
packages/flutter/test/semantics/semantics_test.dart
View File

@@ -291,7 +291,7 @@ void main() {
'An invisible SemanticsNode is one whose rect is not on screen hence not reachable for users, and its semantic information is not merged into a visible parent.\n'
'An invisible SemanticsNode makes the accessibility experience confusing, as it does not provide any visual indication when the user selects it via accessibility technologies.\n'
'Consider removing the above invisible SemanticsNodes if they were added by your RenderObject.assembleSemanticsNode implementation, or filing a bug on GitHub:\n'
' https://github.com/flutter/flutter/issues/new?template=2_bug.yml',
' https://github.com/flutter/flutter/issues/new?template=02_bug.yml',
),
),
),
@@ -322,7 +322,7 @@ void main() {
'An invisible SemanticsNode is one whose rect is not on screen hence not reachable for users, and its semantic information is not merged into a visible parent.\n'
'An invisible SemanticsNode makes the accessibility experience confusing, as it does not provide any visual indication when the user selects it via accessibility technologies.\n'
'Consider removing the above invisible SemanticsNodes if they were added by your RenderObject.assembleSemanticsNode implementation, or filing a bug on GitHub:\n'
' https://github.com/flutter/flutter/issues/new?template=2_bug.yml',
' https://github.com/flutter/flutter/issues/new?template=02_bug.yml',
),
),
),

2
packages/flutter_driver/lib/src/driver/web_driver.dart
View File

@@ -323,7 +323,7 @@ class FlutterWebConnection {
'If the test uses VM service extensions provided by the Flutter SDK, '
'then this error is likely caused by a bug in Flutter. Please report it '
'by filing a bug on GitHub:\n'
' https://github.com/flutter/flutter/issues/new?template=2_bug.yml',
' https://github.com/flutter/flutter/issues/new?template=02_bug.yml',
error,
stackTrace,
);

17
packages/flutter_localizations/lib/src/l10n/README.md
View File

@@ -1,7 +1,7 @@
# Material and Cupertino Libraries Localizations
The `.arb` files in this directory contain localized values (primarily
strings) used by the Material and Cupertino libraries. The
strings) used by the Material and Cupertino libraries. The
`generated_material_localizations.dart` and
`generated_cupertino_localizations.dart` files combine all of the
localizations into a single Map that is linked with the rest of
@@ -11,7 +11,6 @@ If you're looking for information about internationalizing Flutter
apps in general, see the
[Internationalizing Flutter Apps](https://flutter.dev/to/internationalization) tutorial.
### Translations for one locale: .arb files
The Material and Cupertino libraries use
@@ -80,7 +79,6 @@ to write.
},
```
### Values with Parameters, Plurals
A few of material translations contain `$variable` tokens. The
@@ -101,7 +99,6 @@ MaterialLocalizations.of(context).aboutListTileTitle(yourAppTitle)
The names of the `$variable` tokens must match the names of the
`MaterialLocalizations` method parameters.
Plurals are handled similarly, with a lookup method that includes a
quantity parameter. For example `selectedRowCountTitle` returns a
string like "1 item selected" or "no items selected".
@@ -149,18 +146,19 @@ section in the Material spec. The Material theme uses the
`TextTheme`, see
[Typography.geometryThemeFor](https://api.flutter.dev/flutter/material/Typography/geometryThemeFor.html).
### 'generated_*_localizations.dart': all of the localizations
### 'generated\_\*\_localizations.dart': all of the localizations
All of the localizations are combined in a single file per library
using the gen_localizations script.
You can see what that script would generate by running:
```dart
dart dev/tools/localization/bin/gen_localizations.dart
```
Actually update the generated files with:
```dart
dart dev/tools/localization/bin/gen_localizations.dart --overwrite
```
@@ -172,10 +170,10 @@ class implementations use these to lookup localized resource values.
The gen_localizations script must be run by hand after .arb files have
been updated. The script optionally takes parameters
1. The path to this directory,
2. The file name prefix (the file name less the locale
suffix) for the .arb files in this directory.
suffix) for the .arb files in this directory.
### Special handling for the Kannada (kn) translations
@@ -211,8 +209,7 @@ Google contributes translations for all the languages supported by
this package. (Googlers, for more details see <go/flutter-l10n>.)
If you have feedback about the translations please
[file an issue on the Flutter github repo](https://github.com/flutter/flutter/issues/new?template=2_bug.yml).
[file an issue on the Flutter github repo](https://github.com/flutter/flutter/issues/new?template=02_bug.yml).
### See Also

2
packages/flutter_tools/lib/src/cache.dart
View File

@@ -1244,7 +1244,7 @@ class ArtifactUpdater {
status.pause();
_logger.printWarning(
'Downloading an artifact that may not be reachable in some environments (e.g. firewalled environments): $url\n'
'This should not have happened. This is likely a Flutter SDK bug. Please file an issue at https://github.com/flutter/flutter/issues/new?template=1_activation.yml',
'This should not have happened. This is likely a Flutter SDK bug. Please file an issue at https://github.com/flutter/flutter/issues/new?template=01_activation.yml',
);
status.resume();
}

2
packages/flutter_tools/lib/src/migrations/swift_package_manager_integration_migration.dart
View File

@@ -179,7 +179,7 @@ class SwiftPackageManagerIntegrationMigration extends ProjectMigrator {
'An error occurred when adding Swift Package Manager integration:\n'
' $e\n\n'
'Swift Package Manager is currently an experimental feature, please file a bug at\n'
' https://github.com/flutter/flutter/issues/new?template=1_activation.yml \n'
' https://github.com/flutter/flutter/issues/new?template=01_activation.yml \n'
'Consider including a copy of the following files in your bug report:\n'
' ${_platform.name}/Runner.xcodeproj/project.pbxproj\n'
' ${_platform.name}/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme '