From 982e00527cff475f152fa97e14a02c82ec527290 Mon Sep 17 00:00:00 2001 From: Brandon DeRosier Date: Wed, 24 May 2023 14:35:23 -0700 Subject: [PATCH] Manually roll Flutter Engine from 0c41b02cd5a6 to c641f6307f08 (#127514) Rolls engine to head with [fixes](https://github.com/flutter/flutter/pull/127505) corresponding to the [latest Dart roll](https://github.com/flutter/engine/pull/42286). --- bin/internal/engine.version | 2 +- bin/internal/fuchsia-linux.version | 2 +- bin/internal/fuchsia-mac.version | 2 +- .../known_broken_documentation.dart | 3 +-- dev/bots/test/analyze_snippet_code_test.dart | 15 ++++++--------- 5 files changed, 10 insertions(+), 14 deletions(-) diff --git a/bin/internal/engine.version b/bin/internal/engine.version index d167bcd338..524c29930c 100644 --- a/bin/internal/engine.version +++ b/bin/internal/engine.version @@ -1 +1 @@ -0c41b02cd5a641e42328403ed5a6e183c473c827 +c641f6307f08c43d45a73aa31ddeb052bc409cd0 diff --git a/bin/internal/fuchsia-linux.version b/bin/internal/fuchsia-linux.version index b3135d9a3f..eb2519674b 100644 --- a/bin/internal/fuchsia-linux.version +++ b/bin/internal/fuchsia-linux.version @@ -1 +1 @@ --dXJ_pnUVwmjscIYm42_OE80nLeouKgHGRsqBD2JoFoC +UYN_Tk7M6_5d2aGIj7a2ozqAEmu8IRjI2H2DFuvNRcIC diff --git a/bin/internal/fuchsia-mac.version b/bin/internal/fuchsia-mac.version index 36cc8e60a5..3fc69100c4 100644 --- a/bin/internal/fuchsia-mac.version +++ b/bin/internal/fuchsia-mac.version @@ -1 +1 @@ -aAjEDVse7qfMt0NqE-x2K0y-JIcvU2XLT8vjCHu2QOsC +qoLy9E5PjnAlICjUbXiXkASNZSrgFBRRsZBVTFpuVB8C diff --git a/dev/bots/test/analyze-snippet-code-test-input/known_broken_documentation.dart b/dev/bots/test/analyze-snippet-code-test-input/known_broken_documentation.dart index 5a64e67b39..a822e88ec0 100644 --- a/dev/bots/test/analyze-snippet-code-test-input/known_broken_documentation.dart +++ b/dev/bots/test/analyze-snippet-code-test-input/known_broken_documentation.dart @@ -144,8 +144,7 @@ /// ``` /// /// ```dart -/// import 'dart:io'; // error (unused_import) -/// final Widget p = Placeholder(); // error (undefined_class, undefined_function, avoid_dynamic_calls) +/// import 'dart:io'; // error (unused_import)/// final Widget p = Placeholder(); // error (undefined_class, undefined_function) /// ``` /// /// ```dart diff --git a/dev/bots/test/analyze_snippet_code_test.dart b/dev/bots/test/analyze_snippet_code_test.dart index c1abd1d157..712052faf6 100644 --- a/dev/bots/test/analyze_snippet_code_test.dart +++ b/dev/bots/test/analyze_snippet_code_test.dart @@ -20,13 +20,10 @@ const List expectedMainErrors = [ 'dev/bots/test/analyze-snippet-code-test-input/known_broken_documentation.dart:134:14: (top-level declaration) (undefined_identifier)', 'dev/bots/test/analyze-snippet-code-test-input/known_broken_documentation.dart:136:21: (top-level declaration) (read_potentially_unassigned_final)', 'dev/bots/test/analyze-snippet-code-test-input/known_broken_documentation.dart:147:12: (self-contained program) (unused_import)', - 'dev/bots/test/analyze-snippet-code-test-input/known_broken_documentation.dart:148:11: (self-contained program) (undefined_class)', - 'dev/bots/test/analyze-snippet-code-test-input/known_broken_documentation.dart:148:22: (self-contained program) (avoid_dynamic_calls)', - 'dev/bots/test/analyze-snippet-code-test-input/known_broken_documentation.dart:148:22: (self-contained program) (undefined_function)', - 'dev/bots/test/analyze-snippet-code-test-input/known_broken_documentation.dart:153:10: (stateful widget) (annotate_overrides)', - 'dev/bots/test/analyze-snippet-code-test-input/known_broken_documentation.dart:153:10: (stateful widget) (must_call_super)', - 'dev/bots/test/analyze-snippet-code-test-input/known_broken_documentation.dart:161:7: (top-level declaration) (undefined_identifier)', - 'dev/bots/test/analyze-snippet-code-test-input/known_broken_documentation.dart:165: Found "```" in code but it did not match RegExp: pattern=^ */// *```dart\$ flags= so something is wrong. Line was: "/// ```"', + 'dev/bots/test/analyze-snippet-code-test-input/known_broken_documentation.dart:152:10: (stateful widget) (annotate_overrides)', + 'dev/bots/test/analyze-snippet-code-test-input/known_broken_documentation.dart:152:10: (stateful widget) (must_call_super)', + 'dev/bots/test/analyze-snippet-code-test-input/known_broken_documentation.dart:160:7: (top-level declaration) (undefined_identifier)', + 'dev/bots/test/analyze-snippet-code-test-input/known_broken_documentation.dart:164: Found "```" in code but it did not match RegExp: pattern=^ */// *```dart\$ flags= so something is wrong. Line was: "/// ```"', 'dev/bots/test/analyze-snippet-code-test-input/short_but_still_broken.dart:9:12: (statement) (invalid_assignment)', 'dev/bots/test/analyze-snippet-code-test-input/short_but_still_broken.dart:18:4: Empty ```dart block in snippet code.', ]; @@ -71,7 +68,7 @@ void main() { final List stderrNoDescriptions = stderrLines.map(removeLintDescriptions).toList(); expect(stderrNoDescriptions, [ ...expectedMainErrors, - 'Found 18 snippet code errors.', + 'Found 15 snippet code errors.', 'See the documentation at the top of dev/bots/analyze_snippet_code.dart for details.', '', // because we end with a newline, split gives us an extra blank line ]); @@ -95,7 +92,7 @@ void main() { expect(stderrNoDescriptions, [ ...expectedUiErrors, ...expectedMainErrors, - 'Found 22 snippet code errors.', + 'Found 19 snippet code errors.', 'See the documentation at the top of dev/bots/analyze_snippet_code.dart for details.', '', // because we end with a newline, split gives us an extra blank line ]);