From 8a580128ee871bc7134eb01005683ca1e248e8d8 Mon Sep 17 00:00:00 2001 From: Hans Muller Date: Mon, 21 Sep 2015 11:40:19 -0700 Subject: [PATCH] Be explicit about the working directory in CONTRIBUTING --- engine/src/flutter/CONTRIBUTING.md | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/engine/src/flutter/CONTRIBUTING.md b/engine/src/flutter/CONTRIBUTING.md index b5f91bc98c..c859a4ba5a 100644 --- a/engine/src/flutter/CONTRIBUTING.md +++ b/engine/src/flutter/CONTRIBUTING.md @@ -13,7 +13,9 @@ To get the code: and make sure it is in your path. * If you haven't configured your machine with an SSH key that's shared by github then follow the directions here: https://help.github.com/articles/generating-ssh-keys/. - * Create a `.gclient` file in an empty directory with the following contents, replacing + * Create an empty directory for your copy of the repository. Call it what you like. For + the sake of the instructions that follow, we'll call it `flutter`. + * Create a `.gclient` in the `flutter` directory with the following contents, replacing ` with your GitHub account name: ``` @@ -21,7 +23,7 @@ solutions = [ { "managed": False, "name": "src", - "url": "git@github.com:/sky_engine.git", + "url": "git@github.com:/engine.git", "custom_deps": {}, "deps_file": "DEPS", "safesync_url": "", @@ -29,7 +31,7 @@ solutions = [ ] target_os = ["android"] ``` - + * `cd flutter` * `gclient sync` * `cd src` * `git remote add upstream git@github.com:flutter/engine.git` @@ -104,7 +106,7 @@ To start working on a patch: * `git fetch upstream` * `git checkout upstream/master -b name_of_your_branch` * Hack away - * `git commit -a` + * `git commit -a -m ""` * `git push origin name_of_your_branch` To send us a pull request: