diff --git a/dev/automated_tests/test_smoke_test/crash1_test.dart b/dev/automated_tests/test_smoke_test/crash1_test.dart index d403913f48..58cfe2040d 100644 --- a/dev/automated_tests/test_smoke_test/crash1_test.dart +++ b/dev/automated_tests/test_smoke_test/crash1_test.dart @@ -11,6 +11,13 @@ import 'package:flutter_test/flutter_test.dart'; void main() { test('test smoke test -- this test should fail', () async { - system.Process.killPid(system.pid, system.ProcessSignal.SIGSEGV); + if (system.Process.killPid(system.pid, system.ProcessSignal.SIGSEGV)) { + print('system.Process.killPid returned before the process ended!'); + print('Sleeping for a few seconds just in case signal delivery is delayed or our signal handler is being slow...'); + system.sleep(const Duration(seconds: 10)); // don't sleep too much, we must not time out + } else { + print('system.Process.killPid reports that the SIGSEGV signal was not delivered!'); + } + print('crash1_test.dart will now probably not crash, which will ruin the test.'); }); -} \ No newline at end of file +} diff --git a/examples/layers/services/lifecycle.dart b/examples/layers/services/lifecycle.dart index 5196c83a88..ff2befe49d 100644 --- a/examples/layers/services/lifecycle.dart +++ b/examples/layers/services/lifecycle.dart @@ -5,6 +5,8 @@ import 'package:flutter/widgets.dart'; class LifecycleWatcher extends StatefulWidget { + const LifecycleWatcher({ Key key }) : super(key: key); + @override _LifecycleWatcherState createState() => new _LifecycleWatcherState(); } @@ -42,7 +44,12 @@ class _LifecycleWatcherState extends State void main() { - runApp(new Center( - child: new LifecycleWatcher() - )); + runApp( + const Directionality( + textDirection: TextDirection.ltr, + child: const Center( + child: const LifecycleWatcher(), + ), + ), + ); } diff --git a/examples/layers/test/smoketests/lib/main_test.dart b/examples/layers/test/smoketests/lib/main_test.dart index b51650666f..738676ab3c 100644 --- a/examples/layers/test/smoketests/lib/main_test.dart +++ b/examples/layers/test/smoketests/lib/main_test.dart @@ -2,12 +2,12 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -import 'package:test/test.dart'; +import 'package:flutter_test/flutter_test.dart'; import '../../../lib/main.dart' as demo; void main() { - test('layers smoketest for lib/main.dart', () { + testWidgets('layers smoketest for lib/main.dart', (WidgetTester tester) { demo.main(); }); } diff --git a/examples/layers/test/smoketests/rendering/custom_coordinate_systems_test.dart b/examples/layers/test/smoketests/rendering/custom_coordinate_systems_test.dart index c6bcf0ad89..332d2a1519 100644 --- a/examples/layers/test/smoketests/rendering/custom_coordinate_systems_test.dart +++ b/examples/layers/test/smoketests/rendering/custom_coordinate_systems_test.dart @@ -2,12 +2,14 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +import 'package:flutter/foundation.dart'; import 'package:test/test.dart'; import '../../../rendering/custom_coordinate_systems.dart' as demo; void main() { test('layers smoketest for rendering/custom_coordinate_systems.dart', () { + FlutterError.onError = (FlutterErrorDetails details) { throw details.exception; }; demo.main(); }); } diff --git a/examples/layers/test/smoketests/rendering/flex_layout_test.dart b/examples/layers/test/smoketests/rendering/flex_layout_test.dart index 1d1f6fe2b4..cac9a58c84 100644 --- a/examples/layers/test/smoketests/rendering/flex_layout_test.dart +++ b/examples/layers/test/smoketests/rendering/flex_layout_test.dart @@ -2,12 +2,14 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +import 'package:flutter/foundation.dart'; import 'package:test/test.dart'; import '../../../rendering/flex_layout.dart' as demo; void main() { test('layers smoketest for rendering/flex_layout.dart', () { + FlutterError.onError = (FlutterErrorDetails details) { throw details.exception; }; demo.main(); }); } diff --git a/examples/layers/test/smoketests/rendering/hello_world_test.dart b/examples/layers/test/smoketests/rendering/hello_world_test.dart index df8932bcd4..ca3bcabf9e 100644 --- a/examples/layers/test/smoketests/rendering/hello_world_test.dart +++ b/examples/layers/test/smoketests/rendering/hello_world_test.dart @@ -2,12 +2,14 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +import 'package:flutter/foundation.dart'; import 'package:test/test.dart'; import '../../../rendering/hello_world.dart' as demo; void main() { test('layers smoketest for rendering/hello_world.dart', () { + FlutterError.onError = (FlutterErrorDetails details) { throw details.exception; }; demo.main(); }); } diff --git a/examples/layers/test/smoketests/rendering/spinning_square_test.dart b/examples/layers/test/smoketests/rendering/spinning_square_test.dart index 78ceb99934..ab0621c887 100644 --- a/examples/layers/test/smoketests/rendering/spinning_square_test.dart +++ b/examples/layers/test/smoketests/rendering/spinning_square_test.dart @@ -2,12 +2,14 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +import 'package:flutter/foundation.dart'; import 'package:test/test.dart'; import '../../../rendering/spinning_square.dart' as demo; void main() { test('layers smoketest for rendering/spinning_square.dart', () { + FlutterError.onError = (FlutterErrorDetails details) { throw details.exception; }; demo.main(); }); } diff --git a/examples/layers/test/smoketests/rendering/touch_input_test.dart b/examples/layers/test/smoketests/rendering/touch_input_test.dart index dae629f5d9..0ffd5eda58 100644 --- a/examples/layers/test/smoketests/rendering/touch_input_test.dart +++ b/examples/layers/test/smoketests/rendering/touch_input_test.dart @@ -2,12 +2,14 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +import 'package:flutter/foundation.dart'; import 'package:test/test.dart'; import '../../../rendering/touch_input.dart' as demo; void main() { test('layers smoketest for rendering/touch_input.dart', () { + FlutterError.onError = (FlutterErrorDetails details) { throw details.exception; }; demo.main(); }); } diff --git a/examples/layers/test/smoketests/services/isolate_test.dart b/examples/layers/test/smoketests/services/isolate_test.dart index ed5efc1d80..27b98a8e97 100644 --- a/examples/layers/test/smoketests/services/isolate_test.dart +++ b/examples/layers/test/smoketests/services/isolate_test.dart @@ -2,12 +2,12 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -import 'package:test/test.dart'; +import 'package:flutter_test/flutter_test.dart'; import '../../../services/isolate.dart' as demo; void main() { - test('layers smoketest for services/isolate.dart', () { + testWidgets('layers smoketest for services/isolate.dart', (WidgetTester tester) { demo.main(); }); } diff --git a/examples/layers/test/smoketests/services/lifecycle_test.dart b/examples/layers/test/smoketests/services/lifecycle_test.dart index fa6f4ce067..c8290b09e5 100644 --- a/examples/layers/test/smoketests/services/lifecycle_test.dart +++ b/examples/layers/test/smoketests/services/lifecycle_test.dart @@ -2,12 +2,12 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -import 'package:test/test.dart'; +import 'package:flutter_test/flutter_test.dart'; import '../../../services/lifecycle.dart' as demo; void main() { - test('layers smoketest for services/lifecycle.dart', () { + testWidgets('layers smoketest for services/lifecycle.dart', (WidgetTester tester) { demo.main(); }); } diff --git a/examples/layers/test/smoketests/widgets/custom_render_box_test.dart b/examples/layers/test/smoketests/widgets/custom_render_box_test.dart index 2744ebbd64..0e724372ae 100644 --- a/examples/layers/test/smoketests/widgets/custom_render_box_test.dart +++ b/examples/layers/test/smoketests/widgets/custom_render_box_test.dart @@ -2,12 +2,12 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -import 'package:test/test.dart'; +import 'package:flutter_test/flutter_test.dart'; import '../../../widgets/custom_render_box.dart' as demo; void main() { - test('layers smoketest for widgets/custom_render_box.dart', () { + testWidgets('layers smoketest for widgets/custom_render_box.dart', (WidgetTester tester) { demo.main(); }); } diff --git a/examples/layers/test/smoketests/widgets/gestures_test.dart b/examples/layers/test/smoketests/widgets/gestures_test.dart index 44f842273d..ed6dc33371 100644 --- a/examples/layers/test/smoketests/widgets/gestures_test.dart +++ b/examples/layers/test/smoketests/widgets/gestures_test.dart @@ -2,12 +2,12 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -import 'package:test/test.dart'; +import 'package:flutter_test/flutter_test.dart'; import '../../../widgets/gestures.dart' as demo; void main() { - test('layers smoketest for widgets/gestures.dart', () { + testWidgets('layers smoketest for widgets/gestures.dart', (WidgetTester tester) { demo.main(); }); } diff --git a/examples/layers/test/smoketests/widgets/hello_world_test.dart b/examples/layers/test/smoketests/widgets/hello_world_test.dart index 0d6cb4e441..031c01dcba 100644 --- a/examples/layers/test/smoketests/widgets/hello_world_test.dart +++ b/examples/layers/test/smoketests/widgets/hello_world_test.dart @@ -2,12 +2,12 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -import 'package:test/test.dart'; +import 'package:flutter_test/flutter_test.dart'; import '../../../widgets/hello_world.dart' as demo; void main() { - test('layers smoketest for widgets/hello_world.dart', () { + testWidgets('layers smoketest for widgets/hello_world.dart', (WidgetTester tester) { demo.main(); }); } diff --git a/examples/layers/test/smoketests/widgets/media_query_test.dart b/examples/layers/test/smoketests/widgets/media_query_test.dart index f7540f8aaa..fa70edfcb0 100644 --- a/examples/layers/test/smoketests/widgets/media_query_test.dart +++ b/examples/layers/test/smoketests/widgets/media_query_test.dart @@ -2,12 +2,12 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -import 'package:test/test.dart'; +import 'package:flutter_test/flutter_test.dart'; import '../../../widgets/media_query.dart' as demo; void main() { - test('layers smoketest for widgets/media_query.dart', () { + testWidgets('layers smoketest for widgets/media_query.dart', (WidgetTester tester) { demo.main(); }); } diff --git a/examples/layers/test/smoketests/widgets/sectors_test.dart b/examples/layers/test/smoketests/widgets/sectors_test.dart index 4171497984..a5f596a84a 100644 --- a/examples/layers/test/smoketests/widgets/sectors_test.dart +++ b/examples/layers/test/smoketests/widgets/sectors_test.dart @@ -2,12 +2,12 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -import 'package:test/test.dart'; +import 'package:flutter_test/flutter_test.dart'; import '../../../widgets/sectors.dart' as demo; void main() { - test('layers smoketest for widgets/sectors.dart', () { + testWidgets('layers smoketest for widgets/sectors.dart', (WidgetTester tester) { demo.main(); }); } diff --git a/examples/layers/test/smoketests/widgets/spinning_mixed_test.dart b/examples/layers/test/smoketests/widgets/spinning_mixed_test.dart index 6cb3bd54de..090a19ecf7 100644 --- a/examples/layers/test/smoketests/widgets/spinning_mixed_test.dart +++ b/examples/layers/test/smoketests/widgets/spinning_mixed_test.dart @@ -2,12 +2,14 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +import 'package:flutter/foundation.dart'; import 'package:test/test.dart'; import '../../../widgets/spinning_mixed.dart' as demo; void main() { test('layers smoketest for widgets/spinning_mixed.dart', () { + FlutterError.onError = (FlutterErrorDetails details) { throw details.exception; }; demo.main(); }); } diff --git a/examples/layers/test/smoketests/widgets/spinning_square_test.dart b/examples/layers/test/smoketests/widgets/spinning_square_test.dart index e24858d12f..01588efdd1 100644 --- a/examples/layers/test/smoketests/widgets/spinning_square_test.dart +++ b/examples/layers/test/smoketests/widgets/spinning_square_test.dart @@ -2,12 +2,12 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -import 'package:test/test.dart'; +import 'package:flutter_test/flutter_test.dart'; import '../../../widgets/spinning_square.dart' as demo; void main() { - test('layers smoketest for widgets/spinning_square.dart', () { + testWidgets('layers smoketest for widgets/spinning_square.dart', (WidgetTester tester) { demo.main(); }); } diff --git a/examples/layers/test/smoketests/widgets/styled_text_test.dart b/examples/layers/test/smoketests/widgets/styled_text_test.dart index 3fc1a05a31..ed29943553 100644 --- a/examples/layers/test/smoketests/widgets/styled_text_test.dart +++ b/examples/layers/test/smoketests/widgets/styled_text_test.dart @@ -2,12 +2,12 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -import 'package:test/test.dart'; +import 'package:flutter_test/flutter_test.dart'; import '../../../widgets/styled_text.dart' as demo; void main() { - test('layers smoketest for widgets/styled_text.dart', () { + testWidgets('layers smoketest for widgets/styled_text.dart', (WidgetTester tester) { demo.main(); }); } diff --git a/examples/layers/widgets/custom_render_box.dart b/examples/layers/widgets/custom_render_box.dart index 6a2b5b4b25..ded29a732a 100644 --- a/examples/layers/widgets/custom_render_box.dart +++ b/examples/layers/widgets/custom_render_box.dart @@ -46,5 +46,14 @@ class Dots extends SingleChildRenderObjectWidget { } void main() { - runApp(const Dots(child: const Center(child: const Text('Touch me!')))); + runApp( + const Directionality( + textDirection: TextDirection.ltr, + child: const Dots( + child: const Center( + child: const Text('Touch me!'), + ), + ), + ), + ); }