From 82b3db052387161a8eed5f98f08080f1a60b7dfb Mon Sep 17 00:00:00 2001 From: Dan Field Date: Thu, 7 Feb 2019 08:53:31 -0800 Subject: [PATCH] Fix versions implementation (flutter/engine#7726) --- engine/src/flutter/lib/ui/versions.cc | 2 +- engine/src/flutter/testing/dart/versions_test.dart | 5 +---- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/engine/src/flutter/lib/ui/versions.cc b/engine/src/flutter/lib/ui/versions.cc index 37c1861324..b044621a86 100644 --- a/engine/src/flutter/lib/ui/versions.cc +++ b/engine/src/flutter/lib/ui/versions.cc @@ -25,7 +25,7 @@ void GetVersions(Dart_NativeArguments args) { } void Versions::RegisterNatives(tonic::DartLibraryNatives* natives) { - natives->Register({{"Versions_getVersions", GetVersions, 1, true}}); + natives->Register({{"Versions_getVersions", GetVersions, 0, true}}); } } // namespace blink diff --git a/engine/src/flutter/testing/dart/versions_test.dart b/engine/src/flutter/testing/dart/versions_test.dart index 4de21ef252..91935c76a5 100644 --- a/engine/src/flutter/testing/dart/versions_test.dart +++ b/engine/src/flutter/testing/dart/versions_test.dart @@ -2,13 +2,10 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// HACK: pretend to be dart.ui in order to access its internals -library dart.ui; +import 'dart:ui'; import 'package:test/test.dart'; -part '../../lib/ui/versions.dart'; - bool _isNotEmpty(String s) { if (s == null || s.isEmpty) { return false;