diff --git a/analysis_options.yaml b/analysis_options.yaml index 0c019287e6..6706b2a9b9 100644 --- a/analysis_options.yaml +++ b/analysis_options.yaml @@ -113,7 +113,7 @@ linter: - empty_constructor_bodies - empty_statements - exhaustive_cases - # - file_names # not yet tested + - file_names - flutter_style_todos - hash_and_equals - implementation_imports @@ -140,7 +140,7 @@ linter: # - only_throw_errors # https://github.com/flutter/flutter/issues/5792 - overridden_fields - package_api_docs - # - package_names # non conforming packages in sdk + - package_names - package_prefixed_library_names # - parameter_assignments # we do this commonly - prefer_adjacent_string_concatenation diff --git a/dev/benchmarks/macrobenchmarks/lib/main.dart b/dev/benchmarks/macrobenchmarks/lib/main.dart index a9bbeafff5..0754a2df5c 100644 --- a/dev/benchmarks/macrobenchmarks/lib/main.dart +++ b/dev/benchmarks/macrobenchmarks/lib/main.dart @@ -12,7 +12,7 @@ import 'src/color_filter_and_fade.dart'; import 'src/cubic_bezier.dart'; import 'src/cull_opacity.dart'; import 'src/filtered_child_animation.dart'; -import 'src/fullscreenTextField.dart'; +import 'src/fullscreen_textfield.dart'; import 'src/heavy_grid_view.dart'; import 'src/large_image_changer.dart'; import 'src/large_images.dart'; diff --git a/dev/benchmarks/macrobenchmarks/lib/src/fullscreenTextField.dart b/dev/benchmarks/macrobenchmarks/lib/src/fullscreen_textfield.dart similarity index 100% rename from dev/benchmarks/macrobenchmarks/lib/src/fullscreenTextField.dart rename to dev/benchmarks/macrobenchmarks/lib/src/fullscreen_textfield.dart diff --git a/dev/bots/analyze.dart b/dev/bots/analyze.dart index 16ffaefe40..aeee35da9f 100644 --- a/dev/bots/analyze.dart +++ b/dev/bots/analyze.dart @@ -99,7 +99,7 @@ Future run(List arguments) async { // Analyze all the sample code in the repo print('$clock Sample code...'); await runCommand(dart, - [path.join(flutterRoot, 'dev', 'bots', 'analyze-sample-code.dart')], + [path.join(flutterRoot, 'dev', 'bots', 'analyze_sample_code.dart')], workingDirectory: flutterRoot, ); diff --git a/dev/bots/analyze-sample-code.dart b/dev/bots/analyze_sample_code.dart similarity index 99% rename from dev/bots/analyze-sample-code.dart rename to dev/bots/analyze_sample_code.dart index b783b0f3af..5b9d7a3586 100644 --- a/dev/bots/analyze-sample-code.dart +++ b/dev/bots/analyze_sample_code.dart @@ -5,7 +5,7 @@ // See ../snippets/README.md for documentation. // To run this, from the root of the Flutter repository: -// bin/cache/dart-sdk/bin/dart dev/bots/analyze-sample-code.dart +// bin/cache/dart-sdk/bin/dart dev/bots/analyze_sample_code.dart import 'dart:io'; diff --git a/dev/bots/test/analyze-sample-code-test-input/known_broken_documentation.dart b/dev/bots/test/analyze-sample-code-test-input/known_broken_documentation.dart index 19291b30ef..21a43b884c 100644 --- a/dev/bots/test/analyze-sample-code-test-input/known_broken_documentation.dart +++ b/dev/bots/test/analyze-sample-code-test-input/known_broken_documentation.dart @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// This file is used by ../analyze-sample-code_test.dart, which depends on the +// This file is used by ../analyze_sample_code_test.dart, which depends on the // precise contents (including especially the comments) of this file. // Examples can assume: diff --git a/dev/bots/test/analyze-sample-code_test.dart b/dev/bots/test/analyze_sample_code_test.dart similarity index 94% rename from dev/bots/test/analyze-sample-code_test.dart rename to dev/bots/test/analyze_sample_code_test.dart index 71c06f8fc6..8a26aefa2c 100644 --- a/dev/bots/test/analyze-sample-code_test.dart +++ b/dev/bots/test/analyze_sample_code_test.dart @@ -7,10 +7,10 @@ import 'dart:io'; import 'common.dart'; void main() { - test('analyze-sample-code', () { + test('analyze_sample_code', () { final ProcessResult process = Process.runSync( '../../bin/cache/dart-sdk/bin/dart', - ['analyze-sample-code.dart', 'test/analyze-sample-code-test-input'], + ['analyze_sample_code.dart', 'test/analyze-sample-code-test-input'], ); final List stdoutLines = process.stdout.toString().split('\n'); final List stderrLines = process.stderr.toString().split('\n') diff --git a/dev/snippets/README.md b/dev/snippets/README.md index 9abdf1f7aa..c46531d8d4 100644 --- a/dev/snippets/README.md +++ b/dev/snippets/README.md @@ -63,7 +63,7 @@ when generating the HTML to put into the Dart docs. #### Analysis -The `../bots/analyze-sample-code.dart` script finds code inside the `@tool +The `../bots/analyze_sample_code.dart` script finds code inside the `@tool snippet` sections and uses the Dart analyzer to check them. There are several kinds of sample code you can specify: @@ -165,7 +165,7 @@ For more information about how to create, use, or update templates, see #### Analysis -The `../bots/analyze-sample-code.dart` script finds code inside the `@tool +The `../bots/analyze_sample_code.dart` script finds code inside the `@tool sample` sections and uses the Dart analyzer to check them after applying the specified template. @@ -222,7 +222,7 @@ generating the entire docs output takes a long time. Instead, you can run the analysis locally with this command from the Flutter root: ``` -TMPDIR=/tmp bin/cache/dart-sdk/bin/dart dev/bots/analyze-sample-code.dart --temp=samples +TMPDIR=/tmp bin/cache/dart-sdk/bin/dart dev/bots/analyze_sample_code.dart --temp=samples ``` This will analyze the samples, and leave the generated files in `/tmp/samples` diff --git a/packages/flutter/test/widgets/semantics_tester_generateTestSemanticsExpressionForCurrentSemanticsTree_test.dart b/packages/flutter/test/widgets/semantics_tester_generate_test_semantics_expression_for_current_semantics_tree_test.dart similarity index 98% rename from packages/flutter/test/widgets/semantics_tester_generateTestSemanticsExpressionForCurrentSemanticsTree_test.dart rename to packages/flutter/test/widgets/semantics_tester_generate_test_semantics_expression_for_current_semantics_tree_test.dart index 87061dfa7f..6b155ae513 100644 --- a/packages/flutter/test/widgets/semantics_tester_generateTestSemanticsExpressionForCurrentSemanticsTree_test.dart +++ b/packages/flutter/test/widgets/semantics_tester_generate_test_semantics_expression_for_current_semantics_tree_test.dart @@ -67,7 +67,7 @@ void _tests() { if (childSearch != null) { return childSearch; } - } else if (entity is File && entity.path.endsWith('semantics_tester_generateTestSemanticsExpressionForCurrentSemanticsTree_test.dart')) { + } else if (entity is File && entity.path.endsWith('semantics_tester_generate_test_semantics_expression_for_current_semantics_tree_test.dart')) { return entity; } }