From 6e189a7452d0cbaa730ec55fd42145a50ee4bd80 Mon Sep 17 00:00:00 2001 From: n7484443 Date: Wed, 17 Jul 2024 07:29:43 +0900 Subject: [PATCH] chore: fix typo korean, cutButtonLabel (#151364) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [Wikipeidia](https://ko.wikipedia.org/wiki/%EC%9E%98%EB%9D%BC%EB%82%B4%EA%B8%B0,_%EB%B3%B5%EC%82%AC,_%EB%B6%99%EC%97%AC%EB%84%A3%EA%B8%B0) In korea, we use '잘라내기', '복사', '붙여넣기', not '잘라냄', '복사', '붙여넣기'. ![image](https://github.com/flutter/flutter/assets/7384324/34845c96-4e7a-4f95-a44c-19f9917f4a6c) e.g.) korean translation site, papago ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --- .../lib/src/l10n/cupertino_ko.arb | 2 +- .../src/l10n/generated_cupertino_localizations.dart | 2 +- .../lib/src/l10n/generated_material_localizations.dart | 2 +- .../flutter_localizations/lib/src/l10n/material_ko.arb | 2 +- .../test/cupertino/translations_test.dart | 10 ++++++++++ .../test/material/translations_test.dart | 10 ++++++++++ 6 files changed, 24 insertions(+), 4 deletions(-) diff --git a/packages/flutter_localizations/lib/src/l10n/cupertino_ko.arb b/packages/flutter_localizations/lib/src/l10n/cupertino_ko.arb index 940f4b9e0a..2e75d2cf54 100644 --- a/packages/flutter_localizations/lib/src/l10n/cupertino_ko.arb +++ b/packages/flutter_localizations/lib/src/l10n/cupertino_ko.arb @@ -15,7 +15,7 @@ "timerPickerMinuteLabelOther": "분", "timerPickerSecondLabelOne": "초", "timerPickerSecondLabelOther": "초", - "cutButtonLabel": "잘라냄", + "cutButtonLabel": "잘라내기", "copyButtonLabel": "복사", "pasteButtonLabel": "붙여넣기", "selectAllButtonLabel": "전체 선택", diff --git a/packages/flutter_localizations/lib/src/l10n/generated_cupertino_localizations.dart b/packages/flutter_localizations/lib/src/l10n/generated_cupertino_localizations.dart index 4be33dc5bf..ebe8952caf 100644 --- a/packages/flutter_localizations/lib/src/l10n/generated_cupertino_localizations.dart +++ b/packages/flutter_localizations/lib/src/l10n/generated_cupertino_localizations.dart @@ -7758,7 +7758,7 @@ class CupertinoLocalizationKo extends GlobalCupertinoLocalizations { String get copyButtonLabel => '복사'; @override - String get cutButtonLabel => '잘라냄'; + String get cutButtonLabel => '잘라내기'; @override String get datePickerDateOrderString => 'ymd'; diff --git a/packages/flutter_localizations/lib/src/l10n/generated_material_localizations.dart b/packages/flutter_localizations/lib/src/l10n/generated_material_localizations.dart index 8b0343cf7e..328966f2e7 100644 --- a/packages/flutter_localizations/lib/src/l10n/generated_material_localizations.dart +++ b/packages/flutter_localizations/lib/src/l10n/generated_material_localizations.dart @@ -24330,7 +24330,7 @@ class MaterialLocalizationKo extends GlobalMaterialLocalizations { String get currentDateLabel => '오늘'; @override - String get cutButtonLabel => '잘라냄'; + String get cutButtonLabel => '잘라내기'; @override String get dateHelpText => 'yyyy.mm.dd'; diff --git a/packages/flutter_localizations/lib/src/l10n/material_ko.arb b/packages/flutter_localizations/lib/src/l10n/material_ko.arb index ef1318d767..0cc2f3a6d8 100644 --- a/packages/flutter_localizations/lib/src/l10n/material_ko.arb +++ b/packages/flutter_localizations/lib/src/l10n/material_ko.arb @@ -24,7 +24,7 @@ "closeButtonLabel": "닫기", "continueButtonLabel": "계속", "copyButtonLabel": "복사", - "cutButtonLabel": "잘라냄", + "cutButtonLabel": "잘라내기", "scanTextButtonLabel": "텍스트 스캔", "okButtonLabel": "확인", "pasteButtonLabel": "붙여넣기", diff --git a/packages/flutter_localizations/test/cupertino/translations_test.dart b/packages/flutter_localizations/test/cupertino/translations_test.dart index e496d07e36..991cdd9192 100644 --- a/packages/flutter_localizations/test/cupertino/translations_test.dart +++ b/packages/flutter_localizations/test/cupertino/translations_test.dart @@ -240,6 +240,16 @@ void main() { expect(localizations.lookUpButtonLabel, '查询'); }); + testWidgets('ko-KR translation for cut, copy, paste label in ButtonLabel', (WidgetTester tester) async { + const Locale locale = Locale('ko'); + expect(GlobalCupertinoLocalizations.delegate.isSupported(locale), isTrue); + final CupertinoLocalizations localizations = await GlobalCupertinoLocalizations.delegate.load(locale); + expect(localizations, isA()); + expect(localizations.cutButtonLabel, '잘라내기'); + expect(localizations.copyButtonLabel, '복사'); + expect(localizations.pasteButtonLabel, '붙여넣기'); + }); + testWidgets('localizations.datePickerDayOfMonth uses the current locale for weekdays', (WidgetTester tester) async { const Locale locale = Locale('zh'); expect(GlobalCupertinoLocalizations.delegate.isSupported(locale), isTrue); diff --git a/packages/flutter_localizations/test/material/translations_test.dart b/packages/flutter_localizations/test/material/translations_test.dart index 95b6bef162..9d876ee58b 100644 --- a/packages/flutter_localizations/test/material/translations_test.dart +++ b/packages/flutter_localizations/test/material/translations_test.dart @@ -559,4 +559,14 @@ void main() { expect(localizations, isA()); expect(localizations.lookUpButtonLabel, '查询'); }); + + testWidgets('zh-CN translation for look up label', (WidgetTester tester) async { + const Locale locale = Locale('ko'); + expect(GlobalCupertinoLocalizations.delegate.isSupported(locale), isTrue); + final MaterialLocalizations localizations = await GlobalMaterialLocalizations.delegate.load(locale); + expect(localizations, isA()); + expect(localizations.cutButtonLabel, '잘라내기'); + expect(localizations.copyButtonLabel, '복사'); + expect(localizations.pasteButtonLabel, '붙여넣기'); + }); }