From 66dd2add7eb686768448379738fca23b0873c0f1 Mon Sep 17 00:00:00 2001 From: Ian Hickson Date: Tue, 12 Oct 2021 11:33:04 -0700 Subject: [PATCH] Add some more new lints (#91659) --- analysis_options.yaml | 6 ++++++ .../android_views/lib/motion_events_page.dart | 6 ++++++ .../hybrid_android_views/lib/motion_events_page.dart | 6 ++++++ packages/flutter/test/rendering/layers_test.dart | 2 +- .../test/general.shard/base/task_queue_test.dart | 2 +- 5 files changed, 20 insertions(+), 2 deletions(-) diff --git a/analysis_options.yaml b/analysis_options.yaml index 3cf379fbac..41fdde6cff 100644 --- a/analysis_options.yaml +++ b/analysis_options.yaml @@ -112,6 +112,7 @@ linter: - empty_catches - empty_constructor_bodies - empty_statements + - eol_at_end_of_file - exhaustive_cases - file_names - flutter_style_todos @@ -162,6 +163,7 @@ linter: - prefer_final_fields - prefer_final_in_for_each - prefer_final_locals + # - prefer_final_parameters # we should enable this one day (see also parameter_assignments) - prefer_for_elements_to_map_fromIterable - prefer_foreach - prefer_function_declarations_over_variables @@ -178,6 +180,7 @@ linter: - prefer_iterable_whereType # - prefer_mixin # Has false positives, see https://github.com/dart-lang/linter/issues/3018 - prefer_null_aware_operators + # - prefer_null_aware_method_calls # "call()" is confusing to people new to the language since it's not documented anywhere - prefer_relative_imports - prefer_single_quotes - prefer_spread_collections @@ -186,6 +189,7 @@ linter: - provide_deprecation_message # - public_member_api_docs # enabled on a case-by-case basis; see e.g. packages/analysis_options.yaml - recursive_getters + # - require_trailing_commas # blocked on https://github.com/dart-lang/sdk/issues/47441 - sized_box_for_whitespace - slash_for_doc_comments - sort_child_properties_last @@ -201,6 +205,7 @@ linter: - unnecessary_await_in_return - unnecessary_brace_in_string_interps - unnecessary_const + - unnecessary_constructor_name # - unnecessary_final # conflicts with prefer_final_locals - unnecessary_getters_setters # - unnecessary_lambdas # has false positives: https://github.com/dart-lang/linter/issues/498 @@ -218,6 +223,7 @@ linter: - unnecessary_this - unrelated_type_equality_checks # - unsafe_html # not yet tested + - use_build_context_synchronously - use_full_hex_values_for_flutter_colors - use_function_type_syntax_for_parameters # - use_if_null_to_convert_nulls_to_bools # not yet tested diff --git a/dev/integration_tests/android_views/lib/motion_events_page.dart b/dev/integration_tests/android_views/lib/motion_events_page.dart index e4753e57e8..b89e55199f 100644 --- a/dev/integration_tests/android_views/lib/motion_events_page.dart +++ b/dev/integration_tests/android_views/lib/motion_events_page.dart @@ -181,8 +181,14 @@ class MotionEventsBodyState extends State { // This test only runs on Android so we can assume path separator is '/'. final File file = File('${outDir?.path}/$kEventsFileName'); await file.writeAsBytes(data.buffer.asUint8List(0, data.lengthInBytes), flush: true); + if (!mounted) { + return; + } showMessage(context, 'Saved original events to ${file.path}'); } catch (e) { + if (!mounted) { + return; + } showMessage(context, 'Failed saving ${e.toString()}'); } } diff --git a/dev/integration_tests/hybrid_android_views/lib/motion_events_page.dart b/dev/integration_tests/hybrid_android_views/lib/motion_events_page.dart index ac136e55cf..e64af563a0 100644 --- a/dev/integration_tests/hybrid_android_views/lib/motion_events_page.dart +++ b/dev/integration_tests/hybrid_android_views/lib/motion_events_page.dart @@ -163,8 +163,14 @@ class MotionEventsBodyState extends State { // This test only runs on Android so we can assume path separator is '/'. final File file = File('${outDir.path}/$kEventsFileName'); await file.writeAsBytes(data.buffer.asUint8List(0, data.lengthInBytes), flush: true); + if (!mounted) { + return; + } showMessage(context, 'Saved original events to ${file.path}'); } catch (e) { + if (!mounted) { + return; + } showMessage(context, 'Failed saving ${e.toString()}'); } } diff --git a/packages/flutter/test/rendering/layers_test.dart b/packages/flutter/test/rendering/layers_test.dart index bade2a540f..934504fc5e 100644 --- a/packages/flutter/test/rendering/layers_test.dart +++ b/packages/flutter/test/rendering/layers_test.dart @@ -649,4 +649,4 @@ class FakeSceneBuilder extends Fake implements SceneBuilder { class FakeOpacityEngineLayer extends FakeEngineLayer implements OpacityEngineLayer {} -class FakeOffsetEngineLayer extends FakeEngineLayer implements OffsetEngineLayer {} \ No newline at end of file +class FakeOffsetEngineLayer extends FakeEngineLayer implements OffsetEngineLayer {} diff --git a/packages/flutter_tools/test/general.shard/base/task_queue_test.dart b/packages/flutter_tools/test/general.shard/base/task_queue_test.dart index 0bb5e8ffff..cf9fbefd9c 100644 --- a/packages/flutter_tools/test/general.shard/base/task_queue_test.dart +++ b/packages/flutter_tools/test/general.shard/base/task_queue_test.dart @@ -95,4 +95,4 @@ void main() { }); } -class TestException implements Exception {} \ No newline at end of file +class TestException implements Exception {}