From 65945baf01599f274bcdcc7a37299cb92f9541d8 Mon Sep 17 00:00:00 2001 From: Kevin Lubick Date: Tue, 19 Sep 2023 10:05:20 -0400 Subject: [PATCH] Add more missing Skia #includes (flutter/engine#46034) Ran into compile errors when refactoring Skia's #includes. This addresses those ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat --- engine/src/flutter/display_list/skia/dl_sk_paint_dispatcher.h | 1 + engine/src/flutter/display_list/skia/dl_sk_types.h | 1 + 2 files changed, 2 insertions(+) diff --git a/engine/src/flutter/display_list/skia/dl_sk_paint_dispatcher.h b/engine/src/flutter/display_list/skia/dl_sk_paint_dispatcher.h index 33c59ff29b..46ca117b55 100644 --- a/engine/src/flutter/display_list/skia/dl_sk_paint_dispatcher.h +++ b/engine/src/flutter/display_list/skia/dl_sk_paint_dispatcher.h @@ -6,6 +6,7 @@ #define FLUTTER_DISPLAY_LIST_SKIA_DL_SK_PAINT_DISPATCHER_H_ #include "flutter/display_list/dl_op_receiver.h" +#include "flutter/display_list/skia/dl_sk_types.h" namespace flutter { diff --git a/engine/src/flutter/display_list/skia/dl_sk_types.h b/engine/src/flutter/display_list/skia/dl_sk_types.h index bd359b64f5..6f66c0629e 100644 --- a/engine/src/flutter/display_list/skia/dl_sk_types.h +++ b/engine/src/flutter/display_list/skia/dl_sk_types.h @@ -15,6 +15,7 @@ #include "third_party/skia/include/core/SkImage.h" #include "third_party/skia/include/core/SkImageFilter.h" #include "third_party/skia/include/core/SkMaskFilter.h" +#include "third_party/skia/include/core/SkPaint.h" #include "third_party/skia/include/core/SkPath.h" #include "third_party/skia/include/core/SkPathEffect.h" #include "third_party/skia/include/core/SkPicture.h"