From 584ef083c7db55397108ff5aedc7a320a41b23f2 Mon Sep 17 00:00:00 2001 From: Chris Bracken Date: Tue, 15 Jan 2019 19:42:55 -0800 Subject: [PATCH] Replace Android-specific check with switch (#24754) Generally, we should always use default-less switches for platform-specific behaviour so we're forced to make a conscious decision on each instance of such behaviour any time we add support for a new platform. --- packages/flutter/lib/src/rendering/editable.dart | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/packages/flutter/lib/src/rendering/editable.dart b/packages/flutter/lib/src/rendering/editable.dart index 10cea2c6e4..95b20c2968 100644 --- a/packages/flutter/lib/src/rendering/editable.dart +++ b/packages/flutter/lib/src/rendering/editable.dart @@ -256,8 +256,14 @@ class RenderEditable extends RenderBox { // TODO(goderbauer): doesn't handle extended grapheme clusters with more than one Unicode scalar value (https://github.com/flutter/flutter/issues/13404). void _handleKeyEvent(RawKeyEvent keyEvent) { - if (defaultTargetPlatform != TargetPlatform.android) - return; + // Only handle key events on Android. + switch (defaultTargetPlatform) { + case TargetPlatform.android: + break; + case TargetPlatform.iOS: + case TargetPlatform.fuchsia: + return; + } if (keyEvent is RawKeyUpEvent) return;