From 4f3220eebc5ffae857fdb5ba70f98440aff7df5e Mon Sep 17 00:00:00 2001 From: Chris Bracken Date: Fri, 2 Jun 2017 15:50:23 -0700 Subject: [PATCH] Improve auto-correct disabling on Android when obscureText is true (flutter/engine#3731) Some keyboards (e.g., on some Samsung devices, SwiftKey) ignore InputType.TYPE_TEXT_FLAG_NO_SUGGESTIONS and require InputType.TYPE_TEXT_VARIATION_PASSWORD. --- .../android/io/flutter/plugin/editing/TextInputPlugin.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/engine/src/flutter/shell/platform/android/io/flutter/plugin/editing/TextInputPlugin.java b/engine/src/flutter/shell/platform/android/io/flutter/plugin/editing/TextInputPlugin.java index 4d517522fd..c46e0ec896 100644 --- a/engine/src/flutter/shell/platform/android/io/flutter/plugin/editing/TextInputPlugin.java +++ b/engine/src/flutter/shell/platform/android/io/flutter/plugin/editing/TextInputPlugin.java @@ -86,8 +86,11 @@ public class TextInputPlugin implements MethodCallHandler { textType |= InputType.TYPE_TEXT_VARIATION_EMAIL_ADDRESS; else if (inputType.equals("TextInputType.url")) textType |= InputType.TYPE_TEXT_VARIATION_URI; - if (obscureText) + if (obscureText) { + // Note: both required. Some devices ignore TYPE_TEXT_FLAG_NO_SUGGESTIONS. textType |= InputType.TYPE_TEXT_FLAG_NO_SUGGESTIONS; + textType |= InputType.TYPE_TEXT_VARIATION_PASSWORD; + } return textType; }