From 465c5dc0a7054f192f4e5d5f4d074fc69479da5a Mon Sep 17 00:00:00 2001 From: godofredoc Date: Mon, 24 Apr 2023 19:53:06 -0700 Subject: [PATCH] [Cleanup] remove type=local from local test/generators. (flutter/engine#41465) The `"type": "local"` property from local test and generators was never used. Removing from configurations. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style --- .../ci/builders/linux_android_debug_engine.json | 6 ++---- .../flutter/ci/builders/linux_host_engine.json | 12 ++++-------- .../src/flutter/ci/builders/mac_host_engine.json | 9 +++------ engine/src/flutter/ci/builders/mac_unopt.json | 15 +++++---------- .../flutter/ci/builders/windows_host_engine.json | 3 +-- 5 files changed, 15 insertions(+), 30 deletions(-) diff --git a/engine/src/flutter/ci/builders/linux_android_debug_engine.json b/engine/src/flutter/ci/builders/linux_android_debug_engine.json index 7dec1432c0..3a0de90982 100644 --- a/engine/src/flutter/ci/builders/linux_android_debug_engine.json +++ b/engine/src/flutter/ci/builders/linux_android_debug_engine.json @@ -44,8 +44,7 @@ "--android-variant", "android_jit_release_x86" ], - "script": "flutter/testing/run_tests.py", - "type": "local" + "script": "flutter/testing/run_tests.py" } ] }, @@ -97,8 +96,7 @@ "--android-variant", "android_debug" ], - "script": "flutter/testing/run_tests.py", - "type": "local" + "script": "flutter/testing/run_tests.py" } ] }, diff --git a/engine/src/flutter/ci/builders/linux_host_engine.json b/engine/src/flutter/ci/builders/linux_host_engine.json index 240bb816bc..32e6bec92c 100644 --- a/engine/src/flutter/ci/builders/linux_host_engine.json +++ b/engine/src/flutter/ci/builders/linux_host_engine.json @@ -60,8 +60,7 @@ "impeller-vulkan", "--engine-capture-core-dump" ], - "script": "flutter/testing/run_tests.py", - "type": "local" + "script": "flutter/testing/run_tests.py" } ] }, @@ -117,8 +116,7 @@ "dart", "--engine-capture-core-dump" ], - "script": "flutter/testing/run_tests.py", - "type": "local" + "script": "flutter/testing/run_tests.py" } ] }, @@ -166,8 +164,7 @@ "dart,engine", "--engine-capture-core-dump" ], - "script": "flutter/testing/run_tests.py", - "type": "local" + "script": "flutter/testing/run_tests.py" } ] }, @@ -224,8 +221,7 @@ "dart,engine,benchmarks", "--engine-capture-core-dump" ], - "script": "flutter/testing/run_tests.py", - "type": "local" + "script": "flutter/testing/run_tests.py" } ] } diff --git a/engine/src/flutter/ci/builders/mac_host_engine.json b/engine/src/flutter/ci/builders/mac_host_engine.json index 4291cb23fd..4c1f791abd 100644 --- a/engine/src/flutter/ci/builders/mac_host_engine.json +++ b/engine/src/flutter/ci/builders/mac_host_engine.json @@ -54,8 +54,7 @@ "dart", "--engine-capture-core-dump" ], - "script": "flutter/testing/run_tests.py", - "type": "local" + "script": "flutter/testing/run_tests.py" } ] }, @@ -108,8 +107,7 @@ "dart,engine", "--engine-capture-core-dump" ], - "script": "flutter/testing/run_tests.py", - "type": "local" + "script": "flutter/testing/run_tests.py" } ] }, @@ -170,8 +168,7 @@ "--type", "dart,engine,impeller-golden" ], - "script": "flutter/testing/run_tests.py", - "type": "local" + "script": "flutter/testing/run_tests.py" } ] }, diff --git a/engine/src/flutter/ci/builders/mac_unopt.json b/engine/src/flutter/ci/builders/mac_unopt.json index c9b4e5042a..a371566337 100644 --- a/engine/src/flutter/ci/builders/mac_unopt.json +++ b/engine/src/flutter/ci/builders/mac_unopt.json @@ -46,8 +46,7 @@ "dart,engine", "--engine-capture-core-dump" ], - "script": "flutter/testing/run_tests.py", - "type": "local" + "script": "flutter/testing/run_tests.py" } ] }, @@ -105,16 +104,14 @@ "--ios-variant", "ios_debug_sim" ], - "script": "flutter/testing/run_tests.py", - "type": "local" + "script": "flutter/testing/run_tests.py" }, { "name": "Scenario App Integration Tests", "parameters": [ "ios_debug_sim" ], - "script": "flutter/testing/scenario_app/run_ios_tests.sh", - "type": "local" + "script": "flutter/testing/scenario_app/run_ios_tests.sh" } ] }, @@ -216,16 +213,14 @@ "--ios-variant", "ios_debug_sim_arm64" ], - "script": "flutter/testing/run_tests.py", - "type": "local" + "script": "flutter/testing/run_tests.py" }, { "name": "Scenario App Integration Tests", "parameters": [ "ios_debug_sim_arm64" ], - "script": "flutter/testing/scenario_app/run_ios_tests.sh", - "type": "local" + "script": "flutter/testing/scenario_app/run_ios_tests.sh" } ] diff --git a/engine/src/flutter/ci/builders/windows_host_engine.json b/engine/src/flutter/ci/builders/windows_host_engine.json index 289fa7bff7..7c7cfc5bcf 100644 --- a/engine/src/flutter/ci/builders/windows_host_engine.json +++ b/engine/src/flutter/ci/builders/windows_host_engine.json @@ -51,8 +51,7 @@ "--type", "engine" ], - "script": "flutter/testing/run_tests.py", - "type": "local" + "script": "flutter/testing/run_tests.py" } ] },