From 45cef3cbcca4c3b688bfe83cf98fb17cfddfc8a8 Mon Sep 17 00:00:00 2001 From: Alexandre Ardhuin Date: Mon, 15 May 2017 09:44:39 +0200 Subject: [PATCH] try use_to_and_as_if_applicable lint (#10078) * try use_to_and_as_if_applicable lint * address review comments --- .analysis_options | 2 +- .analysis_options_repo | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.analysis_options b/.analysis_options index 854a4187fe..2a1fece32f 100644 --- a/.analysis_options +++ b/.analysis_options @@ -137,7 +137,7 @@ linter: - use_rethrow_when_possible # - use_setters_to_change_properties # not yet tested # - use_string_buffers # https://github.com/dart-lang/linter/pull/664 - # - use_to_and_as_if_applicable # not yet tested + # - use_to_and_as_if_applicable # has false positives, so we prefer to catch this by code-review # === pub rules === - package_names diff --git a/.analysis_options_repo b/.analysis_options_repo index 7aa25bfdda..3fbde2cf40 100644 --- a/.analysis_options_repo +++ b/.analysis_options_repo @@ -135,7 +135,7 @@ linter: - use_rethrow_when_possible # - use_setters_to_change_properties # not yet tested # - use_string_buffers # https://github.com/dart-lang/linter/pull/664 - # - use_to_and_as_if_applicable # not yet tested + # - use_to_and_as_if_applicable # has false positives, so we prefer to catch this by code-review # === pub rules === - package_names