diff --git a/dev/devicelab/lib/framework/ios.dart b/dev/devicelab/lib/framework/ios.dart index 6ec5fcb7c1..b3b68cfdca 100644 --- a/dev/devicelab/lib/framework/ios.dart +++ b/dev/devicelab/lib/framework/ios.dart @@ -73,7 +73,7 @@ $specificMessage $_kProvisioningConfigFileEnvironmentVariable variable is not defined in your environment. Please, define it and try again. -Example provisioining xcconfig: +Example provisioning xcconfig: ProvisioningStyle=Manual CODE_SIGN_IDENTITY=... diff --git a/dev/devicelab/lib/tasks/size_tests.dart b/dev/devicelab/lib/tasks/size_tests.dart index 7678ac0078..c90cb8014c 100644 --- a/dev/devicelab/lib/tasks/size_tests.dart +++ b/dev/devicelab/lib/tasks/size_tests.dart @@ -18,6 +18,7 @@ TaskFunction createBasicMaterialAppSizeTest() { if (await sampleDir.exists()) rmTree(sampleDir); + final Stopwatch watch = new Stopwatch(); int releaseSizeInBytes; await inDirectory(Directory.systemTemp, () async { @@ -32,19 +33,26 @@ TaskFunction createBasicMaterialAppSizeTest() { if (deviceOperatingSystem == DeviceOperatingSystem.ios) { await prepareProvisioningCertificates(sampleDir.path); + watch.start(); await flutter('build', options: ['ios', '--release']); + watch.stop(); // IPAs are created manually AFAICT await exec('tar', ['-zcf', 'build/app.ipa', 'build/ios/Release-iphoneos/Runner.app/']); releaseSizeInBytes = await file('${sampleDir.path}/build/app.ipa').length(); } else { + watch.start(); await flutter('build', options: ['apk', '--release']); + watch.stop(); releaseSizeInBytes = await file('${sampleDir.path}/build/app/outputs/apk/app-release.apk').length(); } }); }); return new TaskResult.success( - {'release_size_in_bytes': releaseSizeInBytes}, - benchmarkScoreKeys: ['release_size_in_bytes']); + { + 'release_size_in_bytes': releaseSizeInBytes, + 'build_time_millis': watch.elapsedMilliseconds, + }, + benchmarkScoreKeys: ['release_size_in_bytes', 'build_time_millis']); }; }