From 40e305dc2dff2160211deaa937b1a3e87f3a2d52 Mon Sep 17 00:00:00 2001 From: Adam Barth Date: Wed, 18 Jan 2017 13:18:09 -0800 Subject: [PATCH] Fix analyzer warnings (#7523) I see these errors in Atom on my Mac. I'm not sure why they're not being picked up by the bots. --- packages/flutter/lib/src/rendering/box.dart | 4 ++-- packages/flutter/lib/src/widgets/basic.dart | 2 +- packages/flutter/lib/src/widgets/framework.dart | 2 +- packages/flutter_driver/lib/src/driver.dart | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/flutter/lib/src/rendering/box.dart b/packages/flutter/lib/src/rendering/box.dart index 1c2391a4c4..69ca611f18 100644 --- a/packages/flutter/lib/src/rendering/box.dart +++ b/packages/flutter/lib/src/rendering/box.dart @@ -936,7 +936,7 @@ class _IntrinsicDimensionsCacheEntry { /// these classes, however, you must implement the algorithm yourself. abstract class RenderBox extends RenderObject { @override - void setupParentData(RenderObject child) { + void setupParentData(@checked RenderObject child) { if (child.parentData is! BoxParentData) child.parentData = new BoxParentData(); } @@ -1823,7 +1823,7 @@ abstract class RenderBox extends RenderObject { /// ``` // TODO(ianh): Fix the type of the argument here once https://github.com/dart-lang/sdk/issues/25232 is fixed @override - void handleEvent(PointerEvent event, HitTestEntry entry) { + void handleEvent(PointerEvent event, @checked HitTestEntry entry) { super.handleEvent(event, entry); } diff --git a/packages/flutter/lib/src/widgets/basic.dart b/packages/flutter/lib/src/widgets/basic.dart index a2e825f094..92af1cb654 100644 --- a/packages/flutter/lib/src/widgets/basic.dart +++ b/packages/flutter/lib/src/widgets/basic.dart @@ -2073,7 +2073,7 @@ class Flex extends MultiChildRenderObjectWidget { } @override - void updateRenderObject(BuildContext context, RenderFlex renderObject) { + void updateRenderObject(BuildContext context, @checked RenderFlex renderObject) { renderObject ..direction = direction ..mainAxisAlignment = mainAxisAlignment diff --git a/packages/flutter/lib/src/widgets/framework.dart b/packages/flutter/lib/src/widgets/framework.dart index 0d2c7d5b75..5195cb4f66 100644 --- a/packages/flutter/lib/src/widgets/framework.dart +++ b/packages/flutter/lib/src/widgets/framework.dart @@ -3456,7 +3456,7 @@ abstract class RenderObjectElement extends BuildableElement { } @override - void update(RenderObjectWidget newWidget) { + void update(@checked RenderObjectWidget newWidget) { super.update(newWidget); assert(widget == newWidget); assert(() { _debugUpdateRenderObjectOwner(); return true; }); diff --git a/packages/flutter_driver/lib/src/driver.dart b/packages/flutter_driver/lib/src/driver.dart index df18dcc6ba..f4ed325f92 100644 --- a/packages/flutter_driver/lib/src/driver.dart +++ b/packages/flutter_driver/lib/src/driver.dart @@ -285,7 +285,7 @@ class FlutterDriver { if (_printCommunication) _log.info(message); if (_logCommunicationToFile) { - f.File file = fs.file(p.join(testOutputsDirectory, 'flutter_driver_commands_${_driverId}.log')); + f.File file = fs.file(p.join(testOutputsDirectory, 'flutter_driver_commands_$_driverId.log')); file.createSync(recursive: true); // no-op if file exists file.writeAsStringSync('${new DateTime.now()} $message\n', mode: f.FileMode.APPEND, flush: true); }