From 3b0adbc646561330878bf4546eb697d13f0f28b8 Mon Sep 17 00:00:00 2001 From: Chinmay Garde Date: Mon, 1 Jul 2019 16:58:00 -0700 Subject: [PATCH] Fix warning about settings unavailable GN arg build_glfw_shell (flutter/engine#9642) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This is only available on Darwin & Linux host targets. On Android target builds, the logic amounted to says “Don’t build GLFW on Android targets”. Since GLFW on Android does not make sense and the target does not exist, GN was generating a warning. --- engine/src/flutter/tools/gn | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/engine/src/flutter/tools/gn b/engine/src/flutter/tools/gn index 66413f44fc..b59ac39ba4 100755 --- a/engine/src/flutter/tools/gn +++ b/engine/src/flutter/tools/gn @@ -253,7 +253,8 @@ def to_gn_args(args): if sys.platform == 'darwin': gn_args['mac_sdk_path'] = args.mac_sdk_path - gn_args['build_glfw_shell'] = args.build_glfw_shell + if args.build_glfw_shell: + gn_args['build_glfw_shell'] = True if gn_args['mac_sdk_path'] == '': gn_args['mac_sdk_path'] = os.getenv('FLUTTER_MAC_SDK_PATH', '')