From 39a6ac669fb5dcc85e167284fd56efb4b1e6ddfd Mon Sep 17 00:00:00 2001 From: Jason Simmons Date: Mon, 5 Feb 2024 18:43:27 -0800 Subject: [PATCH] [Impeller] Do not skip the GLES render pass if the command list is empty (flutter/engine#50381) The render pass may need to apply other changes such as painting the clear color. See https://github.com/flutter/flutter/issues/142639 --- .../impeller/renderer/backend/gles/render_pass_gles.cc | 7 ------- 1 file changed, 7 deletions(-) diff --git a/engine/src/flutter/impeller/renderer/backend/gles/render_pass_gles.cc b/engine/src/flutter/impeller/renderer/backend/gles/render_pass_gles.cc index 7a1cfea533..0bb937320c 100644 --- a/engine/src/flutter/impeller/renderer/backend/gles/render_pass_gles.cc +++ b/engine/src/flutter/impeller/renderer/backend/gles/render_pass_gles.cc @@ -151,10 +151,6 @@ struct RenderPassData { const std::shared_ptr& tracer) { TRACE_EVENT0("impeller", "RenderPassGLES::EncodeCommandsInReactor"); - if (commands.empty()) { - return true; - } - const auto& gl = reactor.GetProcTable(); #ifdef IMPELLER_DEBUG tracer->MarkFrameStart(gl); @@ -517,9 +513,6 @@ bool RenderPassGLES::OnEncodeCommands(const Context& context) const { if (!IsValid()) { return false; } - if (commands_.empty()) { - return true; - } const auto& render_target = GetRenderTarget(); if (!render_target.HasColorAttachment(0u)) { return false;