From 35d50a0e16b5d150feeb397e90d23c4cc9ef81d2 Mon Sep 17 00:00:00 2001 From: asiva Date: Wed, 1 Aug 2018 13:45:03 -0700 Subject: [PATCH] Fix issues found running tests //mobile/flutter/tests/app:basic_runner_test_* during a google3 roll. The following exception was being thrown _TypeError: type 'String' is not a subtype of type 'File' ``` 8) utter_command.dart:347:18) /flutter_command.dart:282:33) xt.dart:142:29) --- packages/flutter_tools/lib/src/commands/run.dart | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/packages/flutter_tools/lib/src/commands/run.dart b/packages/flutter_tools/lib/src/commands/run.dart index 730be165f3..f1df87bbd4 100644 --- a/packages/flutter_tools/lib/src/commands/run.dart +++ b/packages/flutter_tools/lib/src/commands/run.dart @@ -364,13 +364,16 @@ class RunCommand extends RunCommandBase { }).toList(); ResidentRunner runner; + final String applicationBinaryPath = argResults['use-application-binary']; if (hotMode) { runner = new HotRunner( flutterDevices, target: targetFile, debuggingOptions: _createDebuggingOptions(), benchmarkMode: argResults['benchmark'], - applicationBinary: argResults['use-application-binary'], + applicationBinary: applicationBinaryPath == null + ? null + : fs.file(applicationBinaryPath), projectRootPath: argResults['project-root'], packagesFilePath: globalResults['packages'], dillOutputPath: argResults['output-dill'], @@ -383,7 +386,9 @@ class RunCommand extends RunCommandBase { target: targetFile, debuggingOptions: _createDebuggingOptions(), traceStartup: traceStartup, - applicationBinary: argResults['use-application-binary'], + applicationBinary: applicationBinaryPath == null + ? null + : fs.file(applicationBinaryPath), stayResident: stayResident, ipv6: ipv6, );