diff --git a/analysis_options.yaml b/analysis_options.yaml index ae7e109c44..a1beef0bf1 100644 --- a/analysis_options.yaml +++ b/analysis_options.yaml @@ -132,6 +132,7 @@ linter: - no_duplicate_case_values - no_logic_in_create_state # - no_runtimeType_toString # ok in tests; we enable this only in packages/ + - noop_primitive_operations - non_constant_identifier_names - null_check_on_nullable_type_parameter - null_closures diff --git a/packages/flutter/lib/src/widgets/media_query.dart b/packages/flutter/lib/src/widgets/media_query.dart index 3f6143c09f..ffbdf8f9cc 100644 --- a/packages/flutter/lib/src/widgets/media_query.dart +++ b/packages/flutter/lib/src/widgets/media_query.dart @@ -274,7 +274,7 @@ class MediaQueryData { /// right: systemGestureInsets.right, /// ), /// child: Slider( - /// value: _currentValue.toDouble(), + /// value: _currentValue, /// onChanged: (double newValue) { /// setState(() { /// _currentValue = newValue; diff --git a/packages/flutter_tools/lib/src/windows/uwptool.dart b/packages/flutter_tools/lib/src/windows/uwptool.dart index bf21c0821b..c0e0c22501 100644 --- a/packages/flutter_tools/lib/src/windows/uwptool.dart +++ b/packages/flutter_tools/lib/src/windows/uwptool.dart @@ -45,7 +45,7 @@ class UwpTool { return []; } final List packageFamilies = []; - for (final String line in result.stdout.toString().split('\n')) { + for (final String line in result.stdout.split('\n')) { final String packageFamily = line.trim(); if (packageFamily.isNotEmpty) { packageFamilies.add(packageFamily); @@ -82,7 +82,7 @@ class UwpTool { return null; } // Read the process ID from stdout. - final int processId = int.tryParse(result.stdout.toString().trim()); + final int processId = int.tryParse(result.stdout.trim()); _logger.printTrace('Launched application $packageFamily with process ID $processId'); return processId; } diff --git a/packages/flutter_tools/lib/src/windows/windows_device.dart b/packages/flutter_tools/lib/src/windows/windows_device.dart index 7ef22506ab..1c59732100 100644 --- a/packages/flutter_tools/lib/src/windows/windows_device.dart +++ b/packages/flutter_tools/lib/src/windows/windows_device.dart @@ -256,7 +256,7 @@ class WindowsUWPDevice extends Device { final List dependencyUris = _getDependencyPaths(buildDirectory, 'x64') .map((String path) => Uri.file(path).toString()) .toList(); - return _uwptool.installApp(packageUri.toString(), dependencyUris); + return _uwptool.installApp(packageUri, dependencyUris); } @override diff --git a/packages/flutter_tools/test/general.shard/android/gradle_errors_test.dart b/packages/flutter_tools/test/general.shard/android/gradle_errors_test.dart index 5040ed1fc5..abb84cfcb0 100644 --- a/packages/flutter_tools/test/general.shard/android/gradle_errors_test.dart +++ b/packages/flutter_tools/test/general.shard/android/gradle_errors_test.dart @@ -681,7 +681,6 @@ assembleProfile '\n' "Note that your app won't be available to users running Android SDKs below 19.\n" 'Alternatively, try to find a version of this plugin that supports these lower versions of the Android SDK.\n' - '' ) ); }, overrides: { @@ -719,7 +718,6 @@ assembleProfile ' checkReleaseBuilds false\n' ' }\n' '}\n' - '' ) ); }, overrides: { @@ -757,7 +755,6 @@ Execution failed for task ':app:generateDebugFeatureTransitiveDeps'. 'To regenerate the lockfiles run: `./gradlew :generateLockfiles` in /android/build.gradle\n' 'To remove dependency locking, remove the `dependencyLocking` from /android/build.gradle\n' '\n' - '' ) ); }, overrides: {