From 2d5c109c4d85f58ba14b92f7aa85bba1bc4607cc Mon Sep 17 00:00:00 2001 From: Robert Ancell Date: Thu, 14 Oct 2021 14:19:01 +1300 Subject: [PATCH] Remove unused present method This is now done by the FlutterCompositor.present_layers_callback. --- engine/src/flutter/shell/platform/linux/fl_engine.cc | 8 +------- .../src/flutter/shell/platform/linux/fl_renderer.cc | 4 ---- .../src/flutter/shell/platform/linux/fl_renderer.h | 12 ------------ 3 files changed, 1 insertion(+), 23 deletions(-) diff --git a/engine/src/flutter/shell/platform/linux/fl_engine.cc b/engine/src/flutter/shell/platform/linux/fl_engine.cc index 0033a3195d..25075d8d79 100644 --- a/engine/src/flutter/shell/platform/linux/fl_engine.cc +++ b/engine/src/flutter/shell/platform/linux/fl_engine.cc @@ -203,13 +203,7 @@ static uint32_t fl_engine_gl_get_fbo(void* user_data) { } static bool fl_engine_gl_present(void* user_data) { - FlEngine* self = static_cast(user_data); - g_autoptr(GError) error = nullptr; - gboolean result = fl_renderer_present(self->renderer, &error); - if (!result) { - g_warning("%s", error->message); - } - return result; + return true; } static bool fl_engine_gl_make_resource_current(void* user_data) { diff --git a/engine/src/flutter/shell/platform/linux/fl_renderer.cc b/engine/src/flutter/shell/platform/linux/fl_renderer.cc index 76cfbfad22..dde23f60d6 100644 --- a/engine/src/flutter/shell/platform/linux/fl_renderer.cc +++ b/engine/src/flutter/shell/platform/linux/fl_renderer.cc @@ -121,10 +121,6 @@ guint32 fl_renderer_get_fbo(FlRenderer* self) { return 0; } -gboolean fl_renderer_present(FlRenderer* self, GError** error) { - return TRUE; -} - gboolean fl_renderer_create_backing_store( FlRenderer* self, const FlutterBackingStoreConfig* config, diff --git a/engine/src/flutter/shell/platform/linux/fl_renderer.h b/engine/src/flutter/shell/platform/linux/fl_renderer.h index 545f7b8f58..d5db38cd0b 100644 --- a/engine/src/flutter/shell/platform/linux/fl_renderer.h +++ b/engine/src/flutter/shell/platform/linux/fl_renderer.h @@ -186,18 +186,6 @@ gboolean fl_renderer_clear_current(FlRenderer* renderer, GError** error); */ guint32 fl_renderer_get_fbo(FlRenderer* renderer); -/** - * fl_renderer_present: - * @renderer: an #FlRenderer. - * @error: (allow-none): #GError location to store the error occurring, or %NULL - * to ignore. - * - * Presents the current frame. - * - * Returns %TRUE if successful. - */ -gboolean fl_renderer_present(FlRenderer* renderer, GError** error); - /** * fl_renderer_create_backing_store: * @renderer: an #FlRenderer.