From 29adfa506092af64c364cf40356e2ab8f9aecd39 Mon Sep 17 00:00:00 2001 From: liyuqian Date: Fri, 5 Apr 2019 11:01:27 -0700 Subject: [PATCH] More detailed comments for engine build windows VM (flutter/engine#8456) To make it clearer what the next step is after the script run. --- .../prepare_windows_server_2016_core.ps1 | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/engine/src/flutter/ci/docker/windows_build/prepare_windows_server_2016_core.ps1 b/engine/src/flutter/ci/docker/windows_build/prepare_windows_server_2016_core.ps1 index 9b2f6ff2d3..f11c1b7a53 100644 --- a/engine/src/flutter/ci/docker/windows_build/prepare_windows_server_2016_core.ps1 +++ b/engine/src/flutter/ci/docker/windows_build/prepare_windows_server_2016_core.ps1 @@ -44,7 +44,22 @@ mkdir c:/flutter/engine curl https://raw.githubusercontent.com/flutter/engine/master/ci/docker/build/engine_gclient ` -o c:/flutter/engine/.gclient -# Once all the environment variables above are loaded correctly, one may test +# Once the above script finishes successfully, one can make an image of the VM +# for the CI test. +# +# For sanity check, one can also test the VM to make sure that Flutter engine +# can be built in that VM. (The test is optional and our current image is made +# before doing these tests. We only did a reboot before making that image to +# ensure environment variables are loaded. However, Cirrus CI seems to have +# problems reading those environment variables so we ended up setting them in +# ".cirrus.yml" manually.) +# +# To test, first reboot of the terminal (or VM) to ensure that environment +# variables "path", "DEPOT_TOOLS_WIN_TOOLCHAIN", and "GYP_MSVS_OVERRIDE_PATH" +# are set. (Those environment variables are not needed for Cirrus CI as Cirrus +# sets those environment variables by itself.) +# +# After all the environment variables above are loaded correctly, one may test # build the engine by: # cd c:/flutter/engine # gclient sync