From 28cb43e60179e2a38f7921eefbcde5b23fa796db Mon Sep 17 00:00:00 2001 From: Darren Austin Date: Sun, 11 Jul 2021 23:17:00 -0700 Subject: [PATCH] Revert "Migrate core devicelab tasks a-f null safety. (#85996)" (#86268) This reverts commit 9d3563a8eaba076f7a4b042764d8abf7e7e0467f. --- dev/devicelab/bin/tasks/analyzer_benchmark.dart | 2 ++ dev/devicelab/bin/tasks/android_defines_test.dart | 2 ++ .../tasks/android_engine_dependency_proxy_test.dart | 4 +++- dev/devicelab/bin/tasks/android_obfuscate_test.dart | 2 ++ .../bin/tasks/android_semantics_integration_test.dart | 2 ++ dev/devicelab/bin/tasks/android_stack_size_test.dart | 2 ++ .../android_view_scroll_perf__timeline_summary.dart | 2 ++ dev/devicelab/bin/tasks/animated_image_gc_perf.dart | 2 ++ .../tasks/animated_placeholder_perf__e2e_summary.dart | 2 ++ ...ion_with_microtasks_perf_ios__timeline_summary.dart | 2 ++ .../bin/tasks/backdrop_filter_perf__e2e_summary.dart | 2 ++ .../tasks/backdrop_filter_perf__timeline_summary.dart | 2 ++ .../backdrop_filter_perf_ios__timeline_summary.dart | 2 ++ .../bin/tasks/basic_material_app_android__compile.dart | 2 ++ .../bin/tasks/basic_material_app_ios__compile.dart | 2 ++ .../bin/tasks/basic_material_app_win__compile.dart | 2 ++ dev/devicelab/bin/tasks/build_aar_module_test.dart | 4 +++- dev/devicelab/bin/tasks/build_aar_plugin_test.dart | 4 +++- .../bin/tasks/build_ios_framework_module_test.dart | 2 ++ dev/devicelab/bin/tasks/build_mode_test.dart | 4 +++- dev/devicelab/bin/tasks/channels_integration_test.dart | 2 ++ .../bin/tasks/channels_integration_test_ios.dart | 2 ++ .../bin/tasks/channels_integration_test_win.dart | 2 ++ dev/devicelab/bin/tasks/codegen_integration_linux.dart | 2 ++ dev/devicelab/bin/tasks/codegen_integration_mac.dart | 2 ++ dev/devicelab/bin/tasks/codegen_integration_win.dart | 2 ++ .../tasks/color_filter_and_fade_perf__e2e_summary.dart | 2 ++ .../color_filter_and_fade_perf__timeline_summary.dart | 2 ++ dev/devicelab/bin/tasks/complex_layout__start_up.dart | 2 ++ .../bin/tasks/complex_layout_android__compile.dart | 2 ++ .../complex_layout_android__scroll_smoothness.dart | 2 ++ .../bin/tasks/complex_layout_ios__compile.dart | 2 ++ .../bin/tasks/complex_layout_ios__start_up.dart | 2 ++ .../complex_layout_scroll_perf__devtools_memory.dart | 2 ++ .../bin/tasks/complex_layout_scroll_perf__memory.dart | 2 ++ .../complex_layout_scroll_perf__timeline_summary.dart | 2 ++ ...mplex_layout_scroll_perf_ios__timeline_summary.dart | 2 ++ .../bin/tasks/complex_layout_semantics_perf.dart | 2 ++ .../bin/tasks/complex_layout_win__compile.dart | 2 ++ .../bin/tasks/cubic_bezier_perf__e2e_summary.dart | 2 ++ .../bin/tasks/cubic_bezier_perf__timeline_summary.dart | 2 ++ .../cubic_bezier_perf_sksl_warmup__e2e_summary.dart | 2 ++ ...ubic_bezier_perf_sksl_warmup__timeline_summary.dart | 2 ++ .../bin/tasks/cull_opacity_perf__e2e_summary.dart | 2 ++ .../bin/tasks/cull_opacity_perf__timeline_summary.dart | 2 ++ dev/devicelab/bin/tasks/dart_plugin_registry_test.dart | 2 ++ dev/devicelab/bin/tasks/dartdocs.dart | 2 ++ .../bin/tasks/devtools_profile_start_test.dart | 2 ++ dev/devicelab/bin/tasks/drive_perf_debug_warning.dart | 2 ++ .../tasks/embedded_android_views_integration_test.dart | 2 ++ .../bin/tasks/external_ui_integration_test.dart | 2 ++ .../bin/tasks/external_ui_integration_test_ios.dart | 2 ++ .../fading_child_animation_perf__timeline_summary.dart | 2 ++ .../bin/tasks/fast_scroll_heavy_gridview__memory.dart | 10 ++++++---- .../bin/tasks/fast_scroll_large_images__memory.dart | 6 ++++-- dev/devicelab/bin/tasks/flavors_test.dart | 2 ++ dev/devicelab/bin/tasks/flavors_test_ios.dart | 2 ++ dev/devicelab/bin/tasks/flavors_test_win.dart | 2 ++ 58 files changed, 126 insertions(+), 10 deletions(-) diff --git a/dev/devicelab/bin/tasks/analyzer_benchmark.dart b/dev/devicelab/bin/tasks/analyzer_benchmark.dart index c8d092a049..3ded9ba7fc 100644 --- a/dev/devicelab/bin/tasks/analyzer_benchmark.dart +++ b/dev/devicelab/bin/tasks/analyzer_benchmark.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'package:flutter_devicelab/framework/framework.dart'; import 'package:flutter_devicelab/tasks/analysis.dart'; diff --git a/dev/devicelab/bin/tasks/android_defines_test.dart b/dev/devicelab/bin/tasks/android_defines_test.dart index 2f31c1133f..9774212a1d 100644 --- a/dev/devicelab/bin/tasks/android_defines_test.dart +++ b/dev/devicelab/bin/tasks/android_defines_test.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'package:flutter_devicelab/framework/devices.dart'; import 'package:flutter_devicelab/framework/framework.dart'; import 'package:flutter_devicelab/tasks/integration_tests.dart'; diff --git a/dev/devicelab/bin/tasks/android_engine_dependency_proxy_test.dart b/dev/devicelab/bin/tasks/android_engine_dependency_proxy_test.dart index 314854d0d0..69a663f390 100644 --- a/dev/devicelab/bin/tasks/android_engine_dependency_proxy_test.dart +++ b/dev/devicelab/bin/tasks/android_engine_dependency_proxy_test.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'dart:io'; import 'package:flutter_devicelab/framework/apk_utils.dart'; @@ -18,7 +20,7 @@ Future main() async { await task(() async { section('Find Java'); - final String? javaHome = await findJavaHome(); + final String javaHome = await findJavaHome(); if (javaHome == null) return TaskResult.failure('Could not find Java'); print('\nUsing JAVA_HOME=$javaHome'); diff --git a/dev/devicelab/bin/tasks/android_obfuscate_test.dart b/dev/devicelab/bin/tasks/android_obfuscate_test.dart index 6676a0d61f..7e4429e413 100644 --- a/dev/devicelab/bin/tasks/android_obfuscate_test.dart +++ b/dev/devicelab/bin/tasks/android_obfuscate_test.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'package:flutter_devicelab/framework/apk_utils.dart'; import 'package:flutter_devicelab/framework/framework.dart'; import 'package:flutter_devicelab/framework/task_result.dart'; diff --git a/dev/devicelab/bin/tasks/android_semantics_integration_test.dart b/dev/devicelab/bin/tasks/android_semantics_integration_test.dart index 415fad2eca..d2ce3e47f7 100644 --- a/dev/devicelab/bin/tasks/android_semantics_integration_test.dart +++ b/dev/devicelab/bin/tasks/android_semantics_integration_test.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'package:flutter_devicelab/framework/devices.dart'; import 'package:flutter_devicelab/framework/framework.dart'; import 'package:flutter_devicelab/tasks/integration_tests.dart'; diff --git a/dev/devicelab/bin/tasks/android_stack_size_test.dart b/dev/devicelab/bin/tasks/android_stack_size_test.dart index 80341ffa24..546aef2d79 100644 --- a/dev/devicelab/bin/tasks/android_stack_size_test.dart +++ b/dev/devicelab/bin/tasks/android_stack_size_test.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'package:flutter_devicelab/framework/devices.dart'; import 'package:flutter_devicelab/framework/framework.dart'; import 'package:flutter_devicelab/tasks/perf_tests.dart'; diff --git a/dev/devicelab/bin/tasks/android_view_scroll_perf__timeline_summary.dart b/dev/devicelab/bin/tasks/android_view_scroll_perf__timeline_summary.dart index 1112ba20e8..22e2df478f 100644 --- a/dev/devicelab/bin/tasks/android_view_scroll_perf__timeline_summary.dart +++ b/dev/devicelab/bin/tasks/android_view_scroll_perf__timeline_summary.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'package:flutter_devicelab/framework/devices.dart'; import 'package:flutter_devicelab/framework/framework.dart'; import 'package:flutter_devicelab/tasks/perf_tests.dart'; diff --git a/dev/devicelab/bin/tasks/animated_image_gc_perf.dart b/dev/devicelab/bin/tasks/animated_image_gc_perf.dart index b5fe9f8e0c..65f456ee30 100644 --- a/dev/devicelab/bin/tasks/animated_image_gc_perf.dart +++ b/dev/devicelab/bin/tasks/animated_image_gc_perf.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'package:flutter_devicelab/framework/devices.dart'; import 'package:flutter_devicelab/framework/framework.dart'; import 'package:flutter_devicelab/framework/utils.dart'; diff --git a/dev/devicelab/bin/tasks/animated_placeholder_perf__e2e_summary.dart b/dev/devicelab/bin/tasks/animated_placeholder_perf__e2e_summary.dart index e8986d8930..ec033b3bff 100644 --- a/dev/devicelab/bin/tasks/animated_placeholder_perf__e2e_summary.dart +++ b/dev/devicelab/bin/tasks/animated_placeholder_perf__e2e_summary.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'dart:async'; import 'package:flutter_devicelab/framework/devices.dart'; diff --git a/dev/devicelab/bin/tasks/animation_with_microtasks_perf_ios__timeline_summary.dart b/dev/devicelab/bin/tasks/animation_with_microtasks_perf_ios__timeline_summary.dart index 8ecc0bacff..c84450eda7 100644 --- a/dev/devicelab/bin/tasks/animation_with_microtasks_perf_ios__timeline_summary.dart +++ b/dev/devicelab/bin/tasks/animation_with_microtasks_perf_ios__timeline_summary.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'package:flutter_devicelab/framework/devices.dart'; import 'package:flutter_devicelab/framework/framework.dart'; import 'package:flutter_devicelab/tasks/perf_tests.dart'; diff --git a/dev/devicelab/bin/tasks/backdrop_filter_perf__e2e_summary.dart b/dev/devicelab/bin/tasks/backdrop_filter_perf__e2e_summary.dart index 141e2c23b6..49b216f515 100644 --- a/dev/devicelab/bin/tasks/backdrop_filter_perf__e2e_summary.dart +++ b/dev/devicelab/bin/tasks/backdrop_filter_perf__e2e_summary.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'dart:async'; import 'package:flutter_devicelab/framework/devices.dart'; diff --git a/dev/devicelab/bin/tasks/backdrop_filter_perf__timeline_summary.dart b/dev/devicelab/bin/tasks/backdrop_filter_perf__timeline_summary.dart index 1b59f9da0e..db1ec8f7b9 100644 --- a/dev/devicelab/bin/tasks/backdrop_filter_perf__timeline_summary.dart +++ b/dev/devicelab/bin/tasks/backdrop_filter_perf__timeline_summary.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'package:flutter_devicelab/framework/devices.dart'; import 'package:flutter_devicelab/framework/framework.dart'; import 'package:flutter_devicelab/tasks/perf_tests.dart'; diff --git a/dev/devicelab/bin/tasks/backdrop_filter_perf_ios__timeline_summary.dart b/dev/devicelab/bin/tasks/backdrop_filter_perf_ios__timeline_summary.dart index 6a63a8b916..354d3694ea 100644 --- a/dev/devicelab/bin/tasks/backdrop_filter_perf_ios__timeline_summary.dart +++ b/dev/devicelab/bin/tasks/backdrop_filter_perf_ios__timeline_summary.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'package:flutter_devicelab/framework/devices.dart'; import 'package:flutter_devicelab/framework/framework.dart'; import 'package:flutter_devicelab/tasks/perf_tests.dart'; diff --git a/dev/devicelab/bin/tasks/basic_material_app_android__compile.dart b/dev/devicelab/bin/tasks/basic_material_app_android__compile.dart index cf903c03f9..6b93fad7d7 100644 --- a/dev/devicelab/bin/tasks/basic_material_app_android__compile.dart +++ b/dev/devicelab/bin/tasks/basic_material_app_android__compile.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'package:flutter_devicelab/framework/devices.dart'; import 'package:flutter_devicelab/framework/framework.dart'; import 'package:flutter_devicelab/tasks/perf_tests.dart'; diff --git a/dev/devicelab/bin/tasks/basic_material_app_ios__compile.dart b/dev/devicelab/bin/tasks/basic_material_app_ios__compile.dart index cc6f0f7c2c..e503d0a5ed 100644 --- a/dev/devicelab/bin/tasks/basic_material_app_ios__compile.dart +++ b/dev/devicelab/bin/tasks/basic_material_app_ios__compile.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'package:flutter_devicelab/framework/devices.dart'; import 'package:flutter_devicelab/framework/framework.dart'; import 'package:flutter_devicelab/tasks/perf_tests.dart'; diff --git a/dev/devicelab/bin/tasks/basic_material_app_win__compile.dart b/dev/devicelab/bin/tasks/basic_material_app_win__compile.dart index cf903c03f9..6b93fad7d7 100644 --- a/dev/devicelab/bin/tasks/basic_material_app_win__compile.dart +++ b/dev/devicelab/bin/tasks/basic_material_app_win__compile.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'package:flutter_devicelab/framework/devices.dart'; import 'package:flutter_devicelab/framework/framework.dart'; import 'package:flutter_devicelab/tasks/perf_tests.dart'; diff --git a/dev/devicelab/bin/tasks/build_aar_module_test.dart b/dev/devicelab/bin/tasks/build_aar_module_test.dart index 3a78801ad6..5c03498aff 100644 --- a/dev/devicelab/bin/tasks/build_aar_module_test.dart +++ b/dev/devicelab/bin/tasks/build_aar_module_test.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'dart:io'; import 'package:flutter_devicelab/framework/apk_utils.dart'; @@ -22,7 +24,7 @@ Future main() async { section('Find Java'); - final String? javaHome = await findJavaHome(); + final String javaHome = await findJavaHome(); if (javaHome == null) return TaskResult.failure('Could not find Java'); print('\nUsing JAVA_HOME=$javaHome'); diff --git a/dev/devicelab/bin/tasks/build_aar_plugin_test.dart b/dev/devicelab/bin/tasks/build_aar_plugin_test.dart index e0df9586d1..6f666d2660 100644 --- a/dev/devicelab/bin/tasks/build_aar_plugin_test.dart +++ b/dev/devicelab/bin/tasks/build_aar_plugin_test.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'dart:io'; import 'package:flutter_devicelab/framework/framework.dart'; @@ -18,7 +20,7 @@ Future main() async { section('Find Java'); - final String? javaHome = await findJavaHome(); + final String javaHome = await findJavaHome(); if (javaHome == null) return TaskResult.failure('Could not find Java'); print('\nUsing JAVA_HOME=$javaHome'); diff --git a/dev/devicelab/bin/tasks/build_ios_framework_module_test.dart b/dev/devicelab/bin/tasks/build_ios_framework_module_test.dart index 63b59ab28c..05fd14d5c0 100644 --- a/dev/devicelab/bin/tasks/build_ios_framework_module_test.dart +++ b/dev/devicelab/bin/tasks/build_ios_framework_module_test.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'dart:io'; import 'package:flutter_devicelab/framework/framework.dart'; diff --git a/dev/devicelab/bin/tasks/build_mode_test.dart b/dev/devicelab/bin/tasks/build_mode_test.dart index e73625a9a9..23f739bab5 100644 --- a/dev/devicelab/bin/tasks/build_mode_test.dart +++ b/dev/devicelab/bin/tasks/build_mode_test.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'dart:async'; import 'dart:convert'; import 'dart:io'; @@ -23,7 +25,7 @@ Future runFlutterAndQuit(List args, Device device) async { ); final List stdout = []; final List stderr = []; - int? runExitCode; + int runExitCode; run.stdout.transform(utf8.decoder).transform(const LineSplitter()).listen( (String line) { print('run:stdout: $line'); diff --git a/dev/devicelab/bin/tasks/channels_integration_test.dart b/dev/devicelab/bin/tasks/channels_integration_test.dart index c1cb7b8e8b..e842be1b6c 100644 --- a/dev/devicelab/bin/tasks/channels_integration_test.dart +++ b/dev/devicelab/bin/tasks/channels_integration_test.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'package:flutter_devicelab/framework/devices.dart'; import 'package:flutter_devicelab/framework/framework.dart'; import 'package:flutter_devicelab/tasks/integration_tests.dart'; diff --git a/dev/devicelab/bin/tasks/channels_integration_test_ios.dart b/dev/devicelab/bin/tasks/channels_integration_test_ios.dart index 41f042291c..9445f9b1bb 100644 --- a/dev/devicelab/bin/tasks/channels_integration_test_ios.dart +++ b/dev/devicelab/bin/tasks/channels_integration_test_ios.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'package:flutter_devicelab/framework/devices.dart'; import 'package:flutter_devicelab/framework/framework.dart'; import 'package:flutter_devicelab/tasks/integration_tests.dart'; diff --git a/dev/devicelab/bin/tasks/channels_integration_test_win.dart b/dev/devicelab/bin/tasks/channels_integration_test_win.dart index c1cb7b8e8b..e842be1b6c 100644 --- a/dev/devicelab/bin/tasks/channels_integration_test_win.dart +++ b/dev/devicelab/bin/tasks/channels_integration_test_win.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'package:flutter_devicelab/framework/devices.dart'; import 'package:flutter_devicelab/framework/framework.dart'; import 'package:flutter_devicelab/tasks/integration_tests.dart'; diff --git a/dev/devicelab/bin/tasks/codegen_integration_linux.dart b/dev/devicelab/bin/tasks/codegen_integration_linux.dart index 57eab92aeb..f7dae49a44 100644 --- a/dev/devicelab/bin/tasks/codegen_integration_linux.dart +++ b/dev/devicelab/bin/tasks/codegen_integration_linux.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'dart:io'; import 'package:flutter_devicelab/framework/devices.dart'; diff --git a/dev/devicelab/bin/tasks/codegen_integration_mac.dart b/dev/devicelab/bin/tasks/codegen_integration_mac.dart index a1d76af3e3..2501d7b7b7 100644 --- a/dev/devicelab/bin/tasks/codegen_integration_mac.dart +++ b/dev/devicelab/bin/tasks/codegen_integration_mac.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'dart:io'; import 'package:flutter_devicelab/framework/devices.dart'; diff --git a/dev/devicelab/bin/tasks/codegen_integration_win.dart b/dev/devicelab/bin/tasks/codegen_integration_win.dart index 57eab92aeb..f7dae49a44 100644 --- a/dev/devicelab/bin/tasks/codegen_integration_win.dart +++ b/dev/devicelab/bin/tasks/codegen_integration_win.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'dart:io'; import 'package:flutter_devicelab/framework/devices.dart'; diff --git a/dev/devicelab/bin/tasks/color_filter_and_fade_perf__e2e_summary.dart b/dev/devicelab/bin/tasks/color_filter_and_fade_perf__e2e_summary.dart index 5ec07b7c7f..e63db6ecfe 100644 --- a/dev/devicelab/bin/tasks/color_filter_and_fade_perf__e2e_summary.dart +++ b/dev/devicelab/bin/tasks/color_filter_and_fade_perf__e2e_summary.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'dart:async'; import 'package:flutter_devicelab/framework/devices.dart'; diff --git a/dev/devicelab/bin/tasks/color_filter_and_fade_perf__timeline_summary.dart b/dev/devicelab/bin/tasks/color_filter_and_fade_perf__timeline_summary.dart index 234b43b456..62439a7eb4 100644 --- a/dev/devicelab/bin/tasks/color_filter_and_fade_perf__timeline_summary.dart +++ b/dev/devicelab/bin/tasks/color_filter_and_fade_perf__timeline_summary.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'package:flutter_devicelab/framework/devices.dart'; import 'package:flutter_devicelab/framework/framework.dart'; import 'package:flutter_devicelab/tasks/perf_tests.dart'; diff --git a/dev/devicelab/bin/tasks/complex_layout__start_up.dart b/dev/devicelab/bin/tasks/complex_layout__start_up.dart index 12c6d9a862..c05c700cb2 100644 --- a/dev/devicelab/bin/tasks/complex_layout__start_up.dart +++ b/dev/devicelab/bin/tasks/complex_layout__start_up.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'package:flutter_devicelab/framework/devices.dart'; import 'package:flutter_devicelab/framework/framework.dart'; import 'package:flutter_devicelab/tasks/perf_tests.dart'; diff --git a/dev/devicelab/bin/tasks/complex_layout_android__compile.dart b/dev/devicelab/bin/tasks/complex_layout_android__compile.dart index 4bc85ca1c2..41ad9847cc 100644 --- a/dev/devicelab/bin/tasks/complex_layout_android__compile.dart +++ b/dev/devicelab/bin/tasks/complex_layout_android__compile.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'package:flutter_devicelab/framework/devices.dart'; import 'package:flutter_devicelab/framework/framework.dart'; import 'package:flutter_devicelab/tasks/perf_tests.dart'; diff --git a/dev/devicelab/bin/tasks/complex_layout_android__scroll_smoothness.dart b/dev/devicelab/bin/tasks/complex_layout_android__scroll_smoothness.dart index 7fe5461cc4..0503f77648 100644 --- a/dev/devicelab/bin/tasks/complex_layout_android__scroll_smoothness.dart +++ b/dev/devicelab/bin/tasks/complex_layout_android__scroll_smoothness.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'dart:async'; import 'package:flutter_devicelab/framework/devices.dart'; diff --git a/dev/devicelab/bin/tasks/complex_layout_ios__compile.dart b/dev/devicelab/bin/tasks/complex_layout_ios__compile.dart index d8600c22cb..36fd39a284 100644 --- a/dev/devicelab/bin/tasks/complex_layout_ios__compile.dart +++ b/dev/devicelab/bin/tasks/complex_layout_ios__compile.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'package:flutter_devicelab/framework/devices.dart'; import 'package:flutter_devicelab/framework/framework.dart'; import 'package:flutter_devicelab/tasks/perf_tests.dart'; diff --git a/dev/devicelab/bin/tasks/complex_layout_ios__start_up.dart b/dev/devicelab/bin/tasks/complex_layout_ios__start_up.dart index 2bb3a26924..4548bffb38 100644 --- a/dev/devicelab/bin/tasks/complex_layout_ios__start_up.dart +++ b/dev/devicelab/bin/tasks/complex_layout_ios__start_up.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'package:flutter_devicelab/framework/devices.dart'; import 'package:flutter_devicelab/framework/framework.dart'; import 'package:flutter_devicelab/tasks/perf_tests.dart'; diff --git a/dev/devicelab/bin/tasks/complex_layout_scroll_perf__devtools_memory.dart b/dev/devicelab/bin/tasks/complex_layout_scroll_perf__devtools_memory.dart index de449f3b59..94f0614f99 100644 --- a/dev/devicelab/bin/tasks/complex_layout_scroll_perf__devtools_memory.dart +++ b/dev/devicelab/bin/tasks/complex_layout_scroll_perf__devtools_memory.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'package:flutter_devicelab/framework/devices.dart'; import 'package:flutter_devicelab/framework/framework.dart'; import 'package:flutter_devicelab/framework/utils.dart'; diff --git a/dev/devicelab/bin/tasks/complex_layout_scroll_perf__memory.dart b/dev/devicelab/bin/tasks/complex_layout_scroll_perf__memory.dart index f3784a3b30..8b0146fb7b 100644 --- a/dev/devicelab/bin/tasks/complex_layout_scroll_perf__memory.dart +++ b/dev/devicelab/bin/tasks/complex_layout_scroll_perf__memory.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'package:flutter_devicelab/framework/devices.dart'; import 'package:flutter_devicelab/framework/framework.dart'; import 'package:flutter_devicelab/framework/utils.dart'; diff --git a/dev/devicelab/bin/tasks/complex_layout_scroll_perf__timeline_summary.dart b/dev/devicelab/bin/tasks/complex_layout_scroll_perf__timeline_summary.dart index d4f1878846..95cb14fce0 100644 --- a/dev/devicelab/bin/tasks/complex_layout_scroll_perf__timeline_summary.dart +++ b/dev/devicelab/bin/tasks/complex_layout_scroll_perf__timeline_summary.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'package:flutter_devicelab/framework/devices.dart'; import 'package:flutter_devicelab/framework/framework.dart'; import 'package:flutter_devicelab/tasks/perf_tests.dart'; diff --git a/dev/devicelab/bin/tasks/complex_layout_scroll_perf_ios__timeline_summary.dart b/dev/devicelab/bin/tasks/complex_layout_scroll_perf_ios__timeline_summary.dart index b514d35741..b9a3cd7dd8 100644 --- a/dev/devicelab/bin/tasks/complex_layout_scroll_perf_ios__timeline_summary.dart +++ b/dev/devicelab/bin/tasks/complex_layout_scroll_perf_ios__timeline_summary.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'package:flutter_devicelab/framework/devices.dart'; import 'package:flutter_devicelab/framework/framework.dart'; import 'package:flutter_devicelab/tasks/perf_tests.dart'; diff --git a/dev/devicelab/bin/tasks/complex_layout_semantics_perf.dart b/dev/devicelab/bin/tasks/complex_layout_semantics_perf.dart index ab1d4b7c12..0a40d263f9 100644 --- a/dev/devicelab/bin/tasks/complex_layout_semantics_perf.dart +++ b/dev/devicelab/bin/tasks/complex_layout_semantics_perf.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'dart:io'; import 'package:flutter_devicelab/framework/devices.dart'; diff --git a/dev/devicelab/bin/tasks/complex_layout_win__compile.dart b/dev/devicelab/bin/tasks/complex_layout_win__compile.dart index 4bc85ca1c2..41ad9847cc 100644 --- a/dev/devicelab/bin/tasks/complex_layout_win__compile.dart +++ b/dev/devicelab/bin/tasks/complex_layout_win__compile.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'package:flutter_devicelab/framework/devices.dart'; import 'package:flutter_devicelab/framework/framework.dart'; import 'package:flutter_devicelab/tasks/perf_tests.dart'; diff --git a/dev/devicelab/bin/tasks/cubic_bezier_perf__e2e_summary.dart b/dev/devicelab/bin/tasks/cubic_bezier_perf__e2e_summary.dart index 437982f508..4dfb8c5237 100644 --- a/dev/devicelab/bin/tasks/cubic_bezier_perf__e2e_summary.dart +++ b/dev/devicelab/bin/tasks/cubic_bezier_perf__e2e_summary.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'dart:async'; import 'package:flutter_devicelab/framework/devices.dart'; diff --git a/dev/devicelab/bin/tasks/cubic_bezier_perf__timeline_summary.dart b/dev/devicelab/bin/tasks/cubic_bezier_perf__timeline_summary.dart index 2a1ad712d5..352f559110 100644 --- a/dev/devicelab/bin/tasks/cubic_bezier_perf__timeline_summary.dart +++ b/dev/devicelab/bin/tasks/cubic_bezier_perf__timeline_summary.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'package:flutter_devicelab/framework/devices.dart'; import 'package:flutter_devicelab/framework/framework.dart'; import 'package:flutter_devicelab/tasks/perf_tests.dart'; diff --git a/dev/devicelab/bin/tasks/cubic_bezier_perf_sksl_warmup__e2e_summary.dart b/dev/devicelab/bin/tasks/cubic_bezier_perf_sksl_warmup__e2e_summary.dart index 38d83b1e21..0bad40559a 100644 --- a/dev/devicelab/bin/tasks/cubic_bezier_perf_sksl_warmup__e2e_summary.dart +++ b/dev/devicelab/bin/tasks/cubic_bezier_perf_sksl_warmup__e2e_summary.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'dart:async'; import 'package:flutter_devicelab/framework/devices.dart'; diff --git a/dev/devicelab/bin/tasks/cubic_bezier_perf_sksl_warmup__timeline_summary.dart b/dev/devicelab/bin/tasks/cubic_bezier_perf_sksl_warmup__timeline_summary.dart index 83eb00361c..ae086b4928 100644 --- a/dev/devicelab/bin/tasks/cubic_bezier_perf_sksl_warmup__timeline_summary.dart +++ b/dev/devicelab/bin/tasks/cubic_bezier_perf_sksl_warmup__timeline_summary.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'package:flutter_devicelab/framework/devices.dart'; import 'package:flutter_devicelab/framework/framework.dart'; import 'package:flutter_devicelab/tasks/perf_tests.dart'; diff --git a/dev/devicelab/bin/tasks/cull_opacity_perf__e2e_summary.dart b/dev/devicelab/bin/tasks/cull_opacity_perf__e2e_summary.dart index 593641abac..2e6adeca8b 100644 --- a/dev/devicelab/bin/tasks/cull_opacity_perf__e2e_summary.dart +++ b/dev/devicelab/bin/tasks/cull_opacity_perf__e2e_summary.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'package:flutter_devicelab/framework/devices.dart'; import 'package:flutter_devicelab/framework/framework.dart'; import 'package:flutter_devicelab/tasks/perf_tests.dart'; diff --git a/dev/devicelab/bin/tasks/cull_opacity_perf__timeline_summary.dart b/dev/devicelab/bin/tasks/cull_opacity_perf__timeline_summary.dart index 9840170a09..b51ded429c 100644 --- a/dev/devicelab/bin/tasks/cull_opacity_perf__timeline_summary.dart +++ b/dev/devicelab/bin/tasks/cull_opacity_perf__timeline_summary.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'package:flutter_devicelab/framework/devices.dart'; import 'package:flutter_devicelab/framework/framework.dart'; import 'package:flutter_devicelab/tasks/perf_tests.dart'; diff --git a/dev/devicelab/bin/tasks/dart_plugin_registry_test.dart b/dev/devicelab/bin/tasks/dart_plugin_registry_test.dart index 1688aadf79..1ddd1213c4 100644 --- a/dev/devicelab/bin/tasks/dart_plugin_registry_test.dart +++ b/dev/devicelab/bin/tasks/dart_plugin_registry_test.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'package:flutter_devicelab/framework/framework.dart'; import 'package:flutter_devicelab/tasks/dart_plugin_registry_tests.dart'; diff --git a/dev/devicelab/bin/tasks/dartdocs.dart b/dev/devicelab/bin/tasks/dartdocs.dart index 0bb2d2093c..0a11a2e37b 100644 --- a/dev/devicelab/bin/tasks/dartdocs.dart +++ b/dev/devicelab/bin/tasks/dartdocs.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'package:flutter_devicelab/framework/framework.dart'; import 'package:flutter_devicelab/framework/task_result.dart'; diff --git a/dev/devicelab/bin/tasks/devtools_profile_start_test.dart b/dev/devicelab/bin/tasks/devtools_profile_start_test.dart index 11959b5bc4..5d1f8afe4f 100644 --- a/dev/devicelab/bin/tasks/devtools_profile_start_test.dart +++ b/dev/devicelab/bin/tasks/devtools_profile_start_test.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'package:flutter_devicelab/framework/devices.dart'; import 'package:flutter_devicelab/framework/framework.dart'; import 'package:flutter_devicelab/framework/utils.dart'; diff --git a/dev/devicelab/bin/tasks/drive_perf_debug_warning.dart b/dev/devicelab/bin/tasks/drive_perf_debug_warning.dart index 0390ad891e..08be167624 100644 --- a/dev/devicelab/bin/tasks/drive_perf_debug_warning.dart +++ b/dev/devicelab/bin/tasks/drive_perf_debug_warning.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'package:flutter_devicelab/framework/devices.dart'; import 'package:flutter_devicelab/framework/framework.dart'; import 'package:flutter_devicelab/framework/task_result.dart'; diff --git a/dev/devicelab/bin/tasks/embedded_android_views_integration_test.dart b/dev/devicelab/bin/tasks/embedded_android_views_integration_test.dart index c13bc789f0..8bf3425e8c 100644 --- a/dev/devicelab/bin/tasks/embedded_android_views_integration_test.dart +++ b/dev/devicelab/bin/tasks/embedded_android_views_integration_test.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'package:flutter_devicelab/framework/devices.dart'; import 'package:flutter_devicelab/framework/framework.dart'; import 'package:flutter_devicelab/tasks/integration_tests.dart'; diff --git a/dev/devicelab/bin/tasks/external_ui_integration_test.dart b/dev/devicelab/bin/tasks/external_ui_integration_test.dart index cc0930ea73..793bd5c719 100644 --- a/dev/devicelab/bin/tasks/external_ui_integration_test.dart +++ b/dev/devicelab/bin/tasks/external_ui_integration_test.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'package:flutter_devicelab/framework/devices.dart'; import 'package:flutter_devicelab/framework/framework.dart'; import 'package:flutter_devicelab/tasks/integration_tests.dart'; diff --git a/dev/devicelab/bin/tasks/external_ui_integration_test_ios.dart b/dev/devicelab/bin/tasks/external_ui_integration_test_ios.dart index a573cc1b61..3174d152a6 100644 --- a/dev/devicelab/bin/tasks/external_ui_integration_test_ios.dart +++ b/dev/devicelab/bin/tasks/external_ui_integration_test_ios.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'package:flutter_devicelab/framework/devices.dart'; import 'package:flutter_devicelab/framework/framework.dart'; import 'package:flutter_devicelab/tasks/integration_tests.dart'; diff --git a/dev/devicelab/bin/tasks/fading_child_animation_perf__timeline_summary.dart b/dev/devicelab/bin/tasks/fading_child_animation_perf__timeline_summary.dart index dbed0b3c4d..14ea384c1d 100644 --- a/dev/devicelab/bin/tasks/fading_child_animation_perf__timeline_summary.dart +++ b/dev/devicelab/bin/tasks/fading_child_animation_perf__timeline_summary.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'package:flutter_devicelab/framework/devices.dart'; import 'package:flutter_devicelab/framework/framework.dart'; import 'package:flutter_devicelab/tasks/perf_tests.dart'; diff --git a/dev/devicelab/bin/tasks/fast_scroll_heavy_gridview__memory.dart b/dev/devicelab/bin/tasks/fast_scroll_heavy_gridview__memory.dart index 9c8c38bada..3d7d393339 100644 --- a/dev/devicelab/bin/tasks/fast_scroll_heavy_gridview__memory.dart +++ b/dev/devicelab/bin/tasks/fast_scroll_heavy_gridview__memory.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'package:flutter_devicelab/framework/devices.dart'; import 'package:flutter_devicelab/framework/framework.dart'; import 'package:flutter_devicelab/framework/utils.dart'; @@ -18,7 +20,7 @@ class FastScrollHeavyGridViewMemoryTest extends MemoryTest { ); @override - AndroidDevice? get device => super.device as AndroidDevice?; + AndroidDevice get device => super.device as AndroidDevice; @override int get iterationCount => 5; @@ -27,11 +29,11 @@ class FastScrollHeavyGridViewMemoryTest extends MemoryTest { Future useMemory() async { await launchApp(); await recordStart(); - await device!.shellExec('input', ['swipe', '50 1500 50 50 50']); + await device.shellExec('input', ['swipe', '50 1500 50 50 50']); await Future.delayed(const Duration(milliseconds: 1500)); - await device!.shellExec('input', ['swipe', '50 1500 50 50 50']); + await device.shellExec('input', ['swipe', '50 1500 50 50 50']); await Future.delayed(const Duration(milliseconds: 1500)); - await device!.shellExec('input', ['swipe', '50 1500 50 50 50']); + await device.shellExec('input', ['swipe', '50 1500 50 50 50']); await Future.delayed(const Duration(milliseconds: 1500)); await recordEnd(); } diff --git a/dev/devicelab/bin/tasks/fast_scroll_large_images__memory.dart b/dev/devicelab/bin/tasks/fast_scroll_large_images__memory.dart index 26b76c2a41..e61adf6c7e 100644 --- a/dev/devicelab/bin/tasks/fast_scroll_large_images__memory.dart +++ b/dev/devicelab/bin/tasks/fast_scroll_large_images__memory.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'package:flutter_devicelab/framework/devices.dart'; import 'package:flutter_devicelab/framework/framework.dart'; import 'package:flutter_devicelab/framework/utils.dart'; @@ -18,7 +20,7 @@ class FastScrollLargeImagesMemoryTest extends MemoryTest { ); @override - AndroidDevice? get device => super.device as AndroidDevice?; + AndroidDevice get device => super.device as AndroidDevice; @override int get iterationCount => 5; @@ -27,7 +29,7 @@ class FastScrollLargeImagesMemoryTest extends MemoryTest { Future useMemory() async { await launchApp(); await recordStart(); - await device!.shellExec('input', ['swipe', '0 1500 0 0 50']); + await device.shellExec('input', ['swipe', '0 1500 0 0 50']); await Future.delayed(const Duration(milliseconds: 15000)); await recordEnd(); } diff --git a/dev/devicelab/bin/tasks/flavors_test.dart b/dev/devicelab/bin/tasks/flavors_test.dart index b8fbade661..92e1522b6e 100644 --- a/dev/devicelab/bin/tasks/flavors_test.dart +++ b/dev/devicelab/bin/tasks/flavors_test.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'package:flutter_devicelab/framework/devices.dart'; import 'package:flutter_devicelab/framework/framework.dart'; import 'package:flutter_devicelab/tasks/integration_tests.dart'; diff --git a/dev/devicelab/bin/tasks/flavors_test_ios.dart b/dev/devicelab/bin/tasks/flavors_test_ios.dart index 3fa97b2cf7..c20de247a2 100644 --- a/dev/devicelab/bin/tasks/flavors_test_ios.dart +++ b/dev/devicelab/bin/tasks/flavors_test_ios.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'package:flutter_devicelab/framework/devices.dart'; import 'package:flutter_devicelab/framework/framework.dart'; import 'package:flutter_devicelab/tasks/integration_tests.dart'; diff --git a/dev/devicelab/bin/tasks/flavors_test_win.dart b/dev/devicelab/bin/tasks/flavors_test_win.dart index b8fbade661..92e1522b6e 100644 --- a/dev/devicelab/bin/tasks/flavors_test_win.dart +++ b/dev/devicelab/bin/tasks/flavors_test_win.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @dart = 2.8 + import 'package:flutter_devicelab/framework/devices.dart'; import 'package:flutter_devicelab/framework/framework.dart'; import 'package:flutter_devicelab/tasks/integration_tests.dart';