diff --git a/packages/flutter_goldens/lib/skia_client.dart b/packages/flutter_goldens/lib/skia_client.dart index 4ed4ff8529..dc816def60 100644 --- a/packages/flutter_goldens/lib/skia_client.dart +++ b/packages/flutter_goldens/lib/skia_client.dart @@ -579,7 +579,11 @@ class SkiaGoldClient { final Map parameters = { if (_isBrowserTest) 'Browser' : _browserKey, - 'Abi': '$abi', + // This method is only used in local testing to look up the given image. + // CI is not comprehensive in possible abi keys, so false negatives can + // be produced if we include it in local testing. For example CI uses + // macos_x64 but a contributor could have macos_arm64. + // 'Abi': '$abi', 'CI' : 'luci', 'Platform' : platform.operatingSystem, if (webRenderer != null) diff --git a/packages/flutter_goldens/test/flutter_goldens_test.dart b/packages/flutter_goldens/test/flutter_goldens_test.dart index c4b251a9dc..c08670db0f 100644 --- a/packages/flutter_goldens/test/flutter_goldens_test.dart +++ b/packages/flutter_goldens/test/flutter_goldens_test.dart @@ -514,7 +514,7 @@ void main() { expect( skiaClient.getTraceID('flutter.golden.1'), - equals('d8867d66b8f0be8d0c31598d8370f5dd'), + equals('ae18c7a6aa48e0685525dfe8fdf79003'), ); }); @@ -548,7 +548,7 @@ void main() { expect( skiaClient.getTraceID('flutter.golden.1'), - equals('febd0e8ef6512c2a82c964b2a9e60012'), + equals('e9d5c296c48e7126808520e9cc191243'), ); }); @@ -576,7 +576,7 @@ void main() { ); expect( skiaClient.getTraceID('flutter.golden.1'), - equals('2e3d3f41cb4470748fa1c941f7762823'), + equals('9968695b9ae78cdb77cbb2be621ca2d6'), ); });