From 228a011707242d8e20cedc25a3825b08b30b3a46 Mon Sep 17 00:00:00 2001 From: Andrew Kolos Date: Fri, 28 Mar 2025 06:43:13 -0700 Subject: [PATCH] Delete some verbose vm service logging (#162709) Deletes some logging that should no longer be needed.
Pre-launch checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
[Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --- packages/flutter_tools/lib/src/vmservice.dart | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/packages/flutter_tools/lib/src/vmservice.dart b/packages/flutter_tools/lib/src/vmservice.dart index 89d2ad1dfc..d06a9c595a 100644 --- a/packages/flutter_tools/lib/src/vmservice.dart +++ b/packages/flutter_tools/lib/src/vmservice.dart @@ -562,21 +562,6 @@ class FlutterVmService { } } - // TODO(andrewkolos): this is to assist in troubleshooting - // https://github.com/flutter/flutter/issues/152220 and should be reverted - // once this issue is resolved. - final StreamSubscription onReceiveSubscription = service.onReceive.listen(( - String message, - ) { - globals.logger.printTrace('runInView VM service onReceive listener received "$message"'); - final dynamic messageAsJson = jsonDecode(message); - // ignore: avoid_dynamic_calls -- Temporary code. - final dynamic messageKind = messageAsJson['params']?['event']?['kind']; - if (messageKind == 'IsolateRunnable') { - globals.logger.printTrace('Received IsolateRunnable event from onReceive.'); - } - }); - final Future onRunnable = service.onIsolateEvent.firstWhere((vm_service.Event event) { return event.kind == vm_service.EventKind.kIsolateRunnable; }); @@ -589,7 +574,6 @@ class FlutterVmService { }, ); await onRunnable; - await onReceiveSubscription.cancel(); } Future flutterDebugDumpApp({required String isolateId}) async {