diff --git a/engine/src/flutter/impeller/display_list/dl_playground.cc b/engine/src/flutter/impeller/display_list/dl_playground.cc index 587f270f8e..cc18de9ceb 100644 --- a/engine/src/flutter/impeller/display_list/dl_playground.cc +++ b/engine/src/flutter/impeller/display_list/dl_playground.cc @@ -40,11 +40,6 @@ bool DlPlayground::OpenPlaygroundHere(DisplayListPlaygroundCallback callback) { } return Playground::OpenPlaygroundHere( [&context, &callback](RenderTarget& render_target) -> bool { - static bool wireframe = false; - if (ImGui::IsKeyPressed(ImGuiKey_Z)) { - wireframe = !wireframe; - context.GetContentContext().SetWireframe(wireframe); - } return RenderToTarget( context.GetContentContext(), // render_target, // diff --git a/engine/src/flutter/impeller/entity/contents/content_context.cc b/engine/src/flutter/impeller/entity/contents/content_context.cc index d1310a18a9..694836f416 100644 --- a/engine/src/flutter/impeller/entity/contents/content_context.cc +++ b/engine/src/flutter/impeller/entity/contents/content_context.cc @@ -475,7 +475,7 @@ void ContentContextOptions::ApplyToPipelineDescriptor( } desc.SetPrimitiveType(primitive_type); - desc.SetPolygonMode(wireframe ? PolygonMode::kLine : PolygonMode::kFill); + desc.SetPolygonMode(PolygonMode::kFill); } std::array, 15> GetPorterDuffSpecConstants( @@ -913,10 +913,6 @@ const Capabilities& ContentContext::GetDeviceCapabilities() const { return *context_->GetCapabilities(); } -void ContentContext::SetWireframe(bool wireframe) { - wireframe_ = wireframe; -} - PipelineRef ContentContext::GetCachedRuntimeEffectPipeline( const std::string& unique_entrypoint_name, const ContentContextOptions& options, diff --git a/engine/src/flutter/impeller/entity/contents/content_context.h b/engine/src/flutter/impeller/entity/contents/content_context.h index 5c91345bcd..1e47e77d43 100644 --- a/engine/src/flutter/impeller/entity/contents/content_context.h +++ b/engine/src/flutter/impeller/entity/contents/content_context.h @@ -97,7 +97,6 @@ struct ContentContextOptions { PixelFormat color_attachment_pixel_format = PixelFormat::kUnknown; bool has_depth_stencil_attachments = true; bool depth_write_enabled = false; - bool wireframe = false; bool is_for_rrect_blur_clear = false; constexpr uint64_t ToKey() const { @@ -110,7 +109,7 @@ struct ContentContextOptions { static_assert(sizeof(color_attachment_pixel_format) == 1); return (is_for_rrect_blur_clear ? 1llu : 0llu) << 0 | - (wireframe ? 1llu : 0llu) << 1 | + (0) << 1 | // // Unused, previously wireframe. (has_depth_stencil_attachments ? 1llu : 0llu) << 2 | (depth_write_enabled ? 1llu : 0llu) << 3 | // enums @@ -240,8 +239,6 @@ class ContentContext { const Capabilities& GetDeviceCapabilities() const; - void SetWireframe(bool wireframe); - using SubpassCallback = std::function; @@ -343,7 +340,6 @@ class ContentContext { std::shared_ptr render_target_cache_; std::shared_ptr host_buffer_; std::shared_ptr empty_texture_; - bool wireframe_ = false; ContentContext(const ContentContext&) = delete; diff --git a/engine/src/flutter/impeller/entity/entity_playground.cc b/engine/src/flutter/impeller/entity/entity_playground.cc index 9feb8c3fb6..b8ce2122a0 100644 --- a/engine/src/flutter/impeller/entity/entity_playground.cc +++ b/engine/src/flutter/impeller/entity/entity_playground.cc @@ -53,11 +53,6 @@ bool EntityPlayground::OpenPlaygroundHere(EntityPlaygroundCallback callback) { return false; } SinglePassCallback pass_callback = [&](RenderPass& pass) -> bool { - static bool wireframe = false; - if (ImGui::IsKeyPressed(ImGuiKey_Z)) { - wireframe = !wireframe; - content_context.SetWireframe(wireframe); - } content_context.GetRenderTargetCache()->Start(); bool result = callback(content_context, pass); content_context.GetRenderTargetCache()->End();