From 1d59196bafdb682b6403edf14ebef0e86a453cdd Mon Sep 17 00:00:00 2001 From: Sumit Bikram Maity Date: Tue, 1 Aug 2023 02:12:11 +0530 Subject: [PATCH] Appended period remove & Uri parsing fix. (#131293) Fixed code for the Uri as it includes the period at the end as the part of Uri parsing previously. As for example: ``` A crash report has been written to /Users/andrewkolos/Desktop/asset_transformers_test/flutter_03.log. ``` Many terminals are unable to follow the link because it includes the period in the end as part of it. This PR simply removes the period in the end so that it is clickable in many systems (e.g. by `alt` -clicking on it in an embedded bash terminal, VSCode). ``` A crash report has been written to /Users/andrewkolos/Desktop/asset_transformers_test/flutter_03.log ``` Fixes: #131166 --- packages/flutter_tools/lib/src/reporting/crash_reporting.dart | 2 +- .../flutter_tools/test/general.shard/crash_reporting_test.dart | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/flutter_tools/lib/src/reporting/crash_reporting.dart b/packages/flutter_tools/lib/src/reporting/crash_reporting.dart index a8fd8da753..df68535ae5 100644 --- a/packages/flutter_tools/lib/src/reporting/crash_reporting.dart +++ b/packages/flutter_tools/lib/src/reporting/crash_reporting.dart @@ -69,7 +69,7 @@ class CrashReporter { /// Prints instructions for filing a bug about the crash. Future informUser(CrashDetails details, File crashFile) async { - _logger.printError('A crash report has been written to ${crashFile.path}.'); + _logger.printError('A crash report has been written to ${crashFile.path}'); _logger.printStatus('This crash may already be reported. Check GitHub for similar crashes.', emphasis: true); final String similarIssuesURL = GitHubTemplateCreator.toolCrashSimilarIssuesURL(details.error.toString()); diff --git a/packages/flutter_tools/test/general.shard/crash_reporting_test.dart b/packages/flutter_tools/test/general.shard/crash_reporting_test.dart index 5bb3fa3675..be8e239437 100644 --- a/packages/flutter_tools/test/general.shard/crash_reporting_test.dart +++ b/packages/flutter_tools/test/general.shard/crash_reporting_test.dart @@ -100,7 +100,7 @@ void main() { expect(logger.statusText, contains('NoPIIFakeDoctorText')); expect(logger.statusText, isNot(contains('Ignored'))); expect(logger.statusText, contains('https://github.com/flutter/flutter/issues/new')); - expect(logger.errorText, contains('A crash report has been written to ${file.path}.')); + expect(logger.errorText.trim(), 'A crash report has been written to ${file.path}'); }); testWithoutContext('suppress analytics', () async {