From 1c3b501f5396c25c869e2ecc5a4f9a08f6172d2d Mon Sep 17 00:00:00 2001 From: John McDole Date: Tue, 10 Sep 2024 16:01:09 -0700 Subject: [PATCH] Missing benchmarks for `foundation/all_elements_bench.dart` (#154954) I missed awaiting a future. Probably should have a lint for unawaited futures... --- dev/benchmarks/microbenchmarks/lib/benchmark_collection.dart | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dev/benchmarks/microbenchmarks/lib/benchmark_collection.dart b/dev/benchmarks/microbenchmarks/lib/benchmark_collection.dart index 28dff09ded..02efa6c2b2 100644 --- a/dev/benchmarks/microbenchmarks/lib/benchmark_collection.dart +++ b/dev/benchmarks/microbenchmarks/lib/benchmark_collection.dart @@ -87,10 +87,10 @@ Future main() async { 'foundation/all_elements_bench.dart', () async { binding.framePolicy = - LiveTestWidgetsFlutterBindingFramePolicy.fullyLive; + LiveTestWidgetsFlutterBindingFramePolicy.benchmarkLive; runApp(const SizedBox.shrink()); // ensure dispose await SchedulerBinding.instance.endOfFrame; - all_elements_bench.execute(); + await all_elements_bench.execute(); } ), ];