From 17f63272a044ed77f3acc08437977757cebdc0b5 Mon Sep 17 00:00:00 2001 From: "auto-submit[bot]" <98614782+auto-submit[bot]@users.noreply.github.com> Date: Tue, 27 Aug 2024 19:30:17 +0000 Subject: [PATCH] Reverts "Uninstall microbenchmarks before running them. (#154183)" (#154200) Reverts: flutter/flutter#154183 Initiated by: zanderso Reason for reverting: microbenchmarks timing out on CI. Original PR Author: jtmcdole Reviewed By: {andrewkolos} This change reverts the following previous change: Flakes in #153828 stem from adb saying the app isn't installed, but then failing to install wtih `-r`. Several other tests uninstall the app before trying to run it. Potential corrects #153828 --- dev/devicelab/lib/tasks/microbenchmarks.dart | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/dev/devicelab/lib/tasks/microbenchmarks.dart b/dev/devicelab/lib/tasks/microbenchmarks.dart index c69da574a5..aa38ab9a57 100644 --- a/dev/devicelab/lib/tasks/microbenchmarks.dart +++ b/dev/devicelab/lib/tasks/microbenchmarks.dart @@ -30,18 +30,6 @@ TaskFunction createMicrobenchmarkTask({ final Directory appDir = dir( path.join(flutterDirectory.path, 'dev/benchmarks/microbenchmarks')); final Process flutterProcess = await inDirectory(appDir, () async { - section('Uninstall microbenchmarks app ($benchmarkPath)'); - - await flutter( - 'install', - options: [ - '-v', - '--uninstall-only', - '-d', - device.deviceId, - ], - ); - final List options = [ '-v', // --release doesn't work on iOS due to code signing issues